Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Modify AccessScope to allow checks for package access level #62704

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Conversation

elsh
Copy link
Contributor

@elsh elsh commented Dec 19, 2022

Add checks to distinguish between public and package access level.
Add enum AccessLimitKind to be used by AccessScope::Value
Resolves rdar://103534243

@elsh
Copy link
Contributor Author

elsh commented Dec 20, 2022

@swift-ci test

@elsh elsh requested review from nkcsgexi and artemcm December 20, 2022 01:28
include/swift/AST/AccessScope.h Outdated Show resolved Hide resolved
lib/AST/DeclContext.cpp Show resolved Hide resolved
Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks reasonable to me.

@elsh
Copy link
Contributor Author

elsh commented Jan 12, 2023

@swift-ci test

@artemcm
Copy link
Contributor

artemcm commented Jan 12, 2023

@elsh could you please squash the commits?

@elsh
Copy link
Contributor Author

elsh commented Jan 13, 2023

@elsh could you please squash the commits?

I usually do it at the time of merge. Is it to make reviews easier or does each commit still show up separately in git log otherwise?

@elsh
Copy link
Contributor Author

elsh commented Jan 13, 2023

@swift-ci test

include/swift/AST/AccessScope.h Outdated Show resolved Hide resolved
include/swift/AST/AccessScope.h Outdated Show resolved Hide resolved
@xedin xedin removed their request for review January 14, 2023 18:42
@elsh
Copy link
Contributor Author

elsh commented Jan 19, 2023

@swift-ci test

@elsh elsh merged commit f26f810 into main Jan 19, 2023
@elsh elsh deleted the es-pkg2 branch January 19, 2023 17:09
@nkcsgexi
Copy link
Contributor

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants