Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options given at select2_options are not used #15

Closed
stephane opened this issue Nov 26, 2012 · 8 comments
Closed

Options given at select2_options are not used #15

stephane opened this issue Nov 26, 2012 · 8 comments

Comments

@stephane
Copy link
Contributor

As exposed in MixedForm test in django-select2 source code, options given to select2_options are not used because width is not an option known of django-select2 and because select2 expects placeholder not placeHolder.

class FooSelect2Field(django_select2.AutoModelSelect2Field):
    queryset = Foo.objects
    search_fields = ['name__icontains, ]

    station = StationSelect2Field(widget=django_select2.AutoHeavySelect2Widget(select2_options={
        'width': '32em',
        'placeholder': _(u"Search foo")
    })
@applegrew
Copy link
Owner

Yes manually pulled many of your changes and merged to master.

@stephane
Copy link
Contributor Author

You've commited your _build directory!
The commit log is difficult to read because your changes aren't atomic (many fixes + version bump in same commit).

@applegrew
Copy link
Owner

Yes. I did that so that user has an offline copy of the doc w/o having to install Sphinx.

@applegrew
Copy link
Owner

Just search for .py on the diff page. :-) Yes, I should have checked them in separately.

@stephane
Copy link
Contributor Author

It's a bad idea IMHO and the documentation is already provided on
readthedocs.

2012/11/27 AppleGrew [email protected]

Yes. I did that so that user has an offline copy of the doc w/o having to
install Sphinx.


Reply to this email directly or view it on GitHubhttps://github.com//issues/15#issuecomment-10758799.

@applegrew
Copy link
Owner

Yup, but this is an offline copy. Many still do not have always on net. Anyway if someone else too objects to this, then I will remove this.

@stephane
Copy link
Contributor Author

Do you will build the documentation (and commit it) each time, someone will fix a typo?!
My git repo will be dirty (changed not in stagging area) each time, I will generate the doc.

Please, remove this directory and it to .gitignore?

@applegrew
Copy link
Owner

Done. In latest commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants