Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: @appworks/doctor without passing any options #1056 #1058

Closed
wants to merge 2 commits into from
Closed

fix: @appworks/doctor without passing any options #1056 #1058

wants to merge 2 commits into from

Conversation

huangguangfa
Copy link

fix: #1056

@huangguangfa
Copy link
Author

fix: #1056

luhc228
luhc228 reviewed Mar 8, 2023
View reviewed changes
packages/doctor/src/index.ts Outdated
return this.scanner.scan(path.isAbsolute(directory) ? directory : path.join(process.cwd(), directory), options);
return this.scanner.scan(
path.isAbsolute(directory) ? directory : path.join(process.cwd(), directory),
options || {},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scan(directory: string, options: IScanOptions = {})

这样会好点，函数体里后面要消费到 options 都不需要 || {} 了

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已调整

@luhc228
Copy link
Contributor

luhc228 commented Mar 15, 2023

版本和 changelog 写一下

@huangguangfa huangguangfa closed this by deleting the head repository Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luhc228 luhc228 luhc228 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When calling the scan method of @appworks/doctor without passing any options, an error is thrown
2 participants
@huangguangfa @luhc228