Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<ins> only with NOTE section needs different styling #88

Open
arai-a opened this issue Oct 17, 2024 · 1 comment
Open

<ins> only with NOTE section needs different styling #88

arai-a opened this issue Oct 17, 2024 · 1 comment

Comments

@arai-a
Copy link
Owner

arai-a commented Oct 17, 2024

https://arai-a.github.io/ecma262-compare/?pr=3450&id=sec-speciesconstructor

similar to #87, but the case where a NOTE section is enclosed by <ins>,
Given <ins> is styled with background, if the child content has its own background for the entire content, the <ins>'s background color is not visible.

we should for example:

  • add margin/padding between <ins> and the inner block elements
  • add border or something
  • use different background color for note section if it's inside ins/del
@arai-a
Copy link
Owner Author

arai-a commented Oct 17, 2024

Actually, the background color is already inherited for things inslide ins/del.
The issue here would be that the background color is almost same between ins and NOTE section

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant