Fix compilation of iconv tests with libcxx 19 #182
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libcxx 18 deprecated the
std::basic_string
template specializations forint16_t
andint32_t
, which are currently used by the iconv tests. The template specializations were removed altogether in libcxx 19, which breaks compilation of the iconv tests. Replaceint16_t
andint32_t
withchar16_t
andchar32_t
to fix compilation with libcxx 19.I added the
static_assert
for checking the sizes ofchar16_t
andchar32_t
as the standard allows them to contain padding bytes.Fixes #181.