Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core Atom HTML Element: A #70

Closed
2 tasks done
arcticicestudio opened this issue Dec 6, 2018 · 0 comments · Fixed by #71
Closed
2 tasks done

Core Atom HTML Element: A #70

arcticicestudio opened this issue Dec 6, 2018 · 0 comments · Fixed by #71
Labels
context-api context-ui type-feature
Milestone
0.3.0

Comments

@arcticicestudio
Copy link
Contributor

arcticicestudio commented Dec 6, 2018 •
edited
Loading

Associated epic: #69

This issue documents the implementation of the core atom A that represents the inline text semantic HTML element <a>. This is a special dynamic and failsafe component since it'll internally use Gatsby Link component to route within the site (internal links) while also being able to link to external data.

URL Routing Utilities

To handle the logic of conditionally rendering a Gatsby Link or a basic <a>, based on the passed target URL (internal & external), utility functions will be implemented to evaluate the passed target.

Tasks

  • Implement the utility functions.
  • Implement the base HTML element component A.
@arcticicestudio arcticicestudio added this to the 0.3.0 milestone Dec 6, 2018
@arcticicestudio arcticicestudio self-assigned this Dec 6, 2018
@arcticicestudio arcticicestudio mentioned this issue Dec 6, 2018
Open
arcticicestudio added a commit that referenced this issue Dec 6, 2018
@arcticicestudio
Implement util functions to match internal routes
cb9000e 
To handle the logic of conditionally rendering a Gatsby Link or a basic
`<a>`, based on the passed target URL (internal & external), this commit
implements the `isRouteInternal` and `isRoutePartiallyMatch` functions
to evaluate the passed target URL.

Associated epic: GH-69
GH-70
arcticicestudio added a commit that referenced this issue Dec 6, 2018
@arcticicestudio
Implement base HTML element component A
e396fb4 
The core atom `A` represents the inline text semantic (1) HTML element
`<a>`. It is a special  dynamic and failsafe component since it
internally uses the Gatsby `Link` component to route within the site
(internal links) while also being able to link to external targets. The
URLs are passed through the `to` and `href` props.

References:
  (1) https://developer.mozilla.org/en-US/docs/Web/HTML/Element#Inline_text_semantics
  (2) https://www.gatsbyjs.org/docs/gatsby-link

Associated epic: GH-69
GH-70
@arcticicestudio arcticicestudio mentioned this issue Dec 6, 2018
Merged
arcticicestudio added a commit that referenced this issue Dec 6, 2018
@arcticicestudio
Merge pull request #71 from arcticicestudio/feature/gh-70-core-atom-h…
75d0e49 
…tml-element-a

Core Atom HTML Element: A
@arcticicestudio arcticicestudio removed their assignment Dec 6, 2018
@arcticicestudio arcticicestudio mentioned this issue Dec 6, 2018
Closed
13 tasks
@arcticicestudio arcticicestudio mentioned this issue Dec 24, 2018
Closed
2 tasks
arcticicestudio added a commit that referenced this issue Dec 24, 2018
@arcticicestudio
Implement core atom component Link
7cf4e04 
Implemented the core atom `Link` that wraps the base HTML element atom
component the `A` (1) and adds matching brand styles to it.

References:
  (1) #70

Associated epic: GH-63
GH-105
@arcticicestudio arcticicestudio mentioned this issue Jan 8, 2019
Closed
2 tasks
arcticicestudio added a commit that referenced this issue Jan 8, 2019
@arcticicestudio
Implement core base HTML atom Button
ff64b75 
It consists of the previously implemented styles and variants and
represents a `<button>` (1). Next to this is can also wrap the base HTML
element atom `A` (2) to handle internal and external links.

References:
  (1) https://developer.mozilla.org/de/docs/Web/HTML/Element/button
  (2) #70

Associated epic: GH-63
GH-110
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
context-api context-ui type-feature
Projects
None yet
Milestone
0.3.0
Development

Successfully merging a pull request may close this issue.

Core Atom HTML Element: A nordtheme/web
1 participant
@arcticicestudio