Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change format of KNX Energy to match specifications #21074

Merged

Conversation

barbudor
Copy link
Contributor

@barbudor barbudor commented Mar 31, 2024

Description:

Related issue (if applicable): fixes #20834

Change the way Energy values are posted to KNX in accordance with the specifications as pointed by @peterphilipp:
image

The Energy are now posted as 4-byte signed integer in Wh (rounded to 1 Wh to get same values as MQTT)

This PR also refactor 2 things:

  • repetitions for KNX enhancement mode
  • auto detection of temp and hum sensors as soon as 1 telemetry is sent
    save 192 bytes of flash on ESP8266

Testing on ESP8266 by @peterphilipp
Testing on ESP32C3 by @Noschvie

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.6
  • The code change is tested and works with Tasmota core ESP32 V.2.0.14
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@arendst
Copy link
Owner

arendst commented Mar 31, 2024

OK. I'll wait for your fiat (or probably citroen in your case ;-) to merge

@barbudor
Copy link
Contributor Author

OK. I'll wait for your fiat (or probably citroen in your case ;-) to merge

I found a lot of signification for FIAT acronym, not sure the one you intended 🙄 https://www.abbreviations.com/FIAT

Anyhow, in my case it is a Renault Espace 🤣

@barbudor barbudor marked this pull request as ready for review March 31, 2024 17:12
@barbudor
Copy link
Contributor Author

good to go @arendst

@arendst arendst merged commit 0422b25 into arendst:development Mar 31, 2024
64 checks passed
pbrinette pushed a commit to pbrinette/Tasmota that referenced this pull request Apr 9, 2024
* take 1

* refactor knx enhancement

* round on energy + auto show temp/hum sensors
@barbudor barbudor deleted the issue20834_knx_energy_wrong_format branch May 18, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong data on KNX bus for Wh measurements
3 participants