Change format of KNX Energy to match specifications #21074
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue (if applicable): fixes #20834
Change the way Energy values are posted to KNX in accordance with the specifications as pointed by @peterphilipp:
The Energy are now posted as 4-byte signed integer in Wh (rounded to 1 Wh to get same values as MQTT)
This PR also refactor 2 things:
save 192 bytes of flash on ESP8266
Testing on ESP8266 by @peterphilipp
Testing on ESP32C3 by @Noschvie
Checklist:
NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass