Fixed void unwanted OTA upgrade when safeboot starts for the first time #21360
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When booting the first time on safeboot partition, an unwanted OTA upgrade from OtaURL would automatically be triggered. This is due to
NvmLoad("otal", "otal", &pOtaLoader, sizeof(pOtaLoader));
not updatingpOtaLoader
since the value does not yet exist in NMV, hence the value would default to a random value from the stack, and generally not0
.This PR sets the default value to
0
so no unwanted OTA is done when NVM is not yet populated.Checklist:
NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass