Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Argo CD openapi validation spec is incomplete #1687

Closed
alexmt opened this issue Jun 4, 2019 · 6 comments
Closed

Argo CD openapi validation spec is incomplete #1687

alexmt opened this issue Jun 4, 2019 · 6 comments
Labels
bug Something isn't working
Milestone
v1.2

Comments

@alexmt
Copy link
Collaborator

alexmt commented Jun 4, 2019

Describe the bug

The openapi validation spec generated by https://github.com/kubernetes-sigs/controller-tools is incomplete. We should switch to controller-gen binary, to generate the CRD definition. It provides validation for all fields of the resource, which we were missing before, allowing a controller to be brought down by a single bad manifest.

Version v1.0.1
@alexmt alexmt added the bug Something isn't working label Jun 4, 2019
@alexec
Copy link
Contributor

alexec commented Jun 4, 2019

Nasty.

@jessesuen
Copy link
Member

Correction: we are not yet on github.com/kubernetes-sigs/controller-tools. We are currently using github.com/ant31/crd-validation and need to switch to github.com/kubernetes-sigs/controller-tools to get the complete spec.

@jessesuen
Copy link
Member

This is how it was done for rollouts: argoproj/argo-rollouts@a6aa76d

@alexec alexec mentioned this issue Jun 6, 2019
Closed
@alexmt alexmt mentioned this issue Jun 18, 2019
Merged
@alexmt
Copy link
Collaborator Author

alexmt commented Jul 1, 2019

Fixed

@alexmt alexmt closed this as completed Jul 1, 2019
@alexec
Copy link
Contributor

alexec commented Jul 1, 2019

In this in v1.2?

@alexmt
Copy link
Collaborator Author

alexmt commented Jul 1, 2019

yes

@alexmt alexmt added this to the v1.2 milestone Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v1.2
Development

No branches or pull requests
3 participants
@alexmt @alexec @jessesuen