Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow connecting from the Notification Controller to the Repo Server without TLS #19629

Closed
m-wynn opened this issue Aug 21, 2024 · 0 comments · Fixed by #19630
Closed

Allow connecting from the Notification Controller to the Repo Server without TLS #19629

m-wynn opened this issue Aug 21, 2024 · 0 comments · Fixed by #19630
Labels
enhancement New feature or request

Comments

@m-wynn
Copy link
Contributor

m-wynn commented Aug 21, 2024

Summary

All of the Argo CD components I have worked with have a way to disable TLS between each other via the argocd-cmd-params-cm ConfigMap. One issue I've run into is, when calling .repo.GetCommitMetadata in notifications templates, it tries to reach out to the Repo Server over TLS. There does not seem to be an easy way to disable it, short of overlaying the notifications template deployment itself and adding a command line flag.

Motivation

This is necessary for environments where Istio is managing mutual TLS between each component (#2784).

Proposal

Similar to the other controllers, we can add notificationscontroller.repo.server.plaintext to the argocd-cmd-params-cm ConfigMap, and then in the deployment template, map that to the ARGOCD_NOTIFICATION_CONTROLLER_REPO_SERVER_PLAINTEXT environment variable. In the go code for the notifications controller, we can attach this to &argocdRepoServerPlaintext. I'm proposing a singular "NOTIFICATION" here to match the existing ARGOCD_NOTIFICATION_CONTROLLER_SELF_SERVICE_ENABLED, but happy to change it.

It should be a small change so I'm happy to make a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant