You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think the CI checks should include snyk container test to check for high-severity issues.
Motivation
The Snyk check that is currently in the Argo CD CI has two shortcomings:
It checks only for new issues, rather than setting a threshold (we want a threshold of "no 'High' severity issues")
It does not generate a report
Proposal
snyk container test --org=argoproj --json-file-output=/tmp/snyk-container.json --severity-threshold=high --file=Dockerfile quay.io/argoproj/argocd:whatever-tag-was-just-built
If snyk container test fails due to high-severity vulnerabilities, investigate those vulnerabilities and either resolve the
vulnerable path (upgrade, use a different library, etc.) or add them to the .snyk file in the root of the repo if they
should be ignored.
If the build is part of a release, use snyk-to-html to build a report and add it
to the release assets.
Summary
I think the CI checks should include
snyk container test
to check for high-severity issues.Motivation
The Snyk check that is currently in the Argo CD CI has two shortcomings:
Proposal
snyk container test --org=argoproj --json-file-output=/tmp/snyk-container.json --severity-threshold=high --file=Dockerfile quay.io/argoproj/argocd:whatever-tag-was-just-built
If
snyk container test
fails due to high-severity vulnerabilities, investigate those vulnerabilities and either resolve thevulnerable path (upgrade, use a different library, etc.) or add them to the .snyk file in the root of the repo if they
should be ignored.
If the build is part of a release, use snyk-to-html to build a report and add it
to the release assets.
See crenshaw-dev/actions-test
for an example.
The text was updated successfully, but these errors were encountered: