Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snyk container test check to CI #8655

Open
crenshaw-dev opened this issue Mar 2, 2022 · 0 comments
Open

Add snyk container test check to CI #8655

crenshaw-dev opened this issue Mar 2, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@crenshaw-dev
Copy link
Member

Summary

I think the CI checks should include snyk container test to check for high-severity issues.

Motivation

The Snyk check that is currently in the Argo CD CI has two shortcomings:

  1. It checks only for new issues, rather than setting a threshold (we want a threshold of "no 'High' severity issues")
  2. It does not generate a report

Proposal

snyk container test --org=argoproj --json-file-output=/tmp/snyk-container.json --severity-threshold=high --file=Dockerfile quay.io/argoproj/argocd:whatever-tag-was-just-built

If snyk container test fails due to high-severity vulnerabilities, investigate those vulnerabilities and either resolve the
vulnerable path (upgrade, use a different library, etc.) or add them to the .snyk file in the root of the repo if they
should be ignored.

If the build is part of a release, use snyk-to-html to build a report and add it
to the release assets.

See crenshaw-dev/actions-test
for an example.

@crenshaw-dev crenshaw-dev added the enhancement New feature or request label Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant