Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conditions reset does not work if the service is down at the triggering time. #1543

Closed
whynowy opened this issue Jan 20, 2022 · 2 comments
Closed

conditions reset does not work if the service is down at the triggering time. #1543

whynowy opened this issue Jan 20, 2022 · 2 comments
Assignees
@juliev0
Labels
bug Something isn't working

Comments

@whynowy
Copy link
Member

whynowy commented Jan 20, 2022

Conditions Reset is a feature for multi dependency triggers to reset the conditions with a cron like schedule. It runs a timer to send a reset signal when the time comes, which will not work if the sensor service is down at the time.

A possible solution to address the issue would be, utilize the message timestamp to compare with the last reset timestamp to see if it is good.
@whynowy whynowy added the bug Something isn't working label Jan 20, 2022
@whynowy whynowy changed the title conditions reset does not work if the service is down at the trigging time. conditions reset does not work if the service is down at the triggering time. Jan 20, 2022
@juliev0
Copy link
Contributor

juliev0 commented Jan 25, 2022

I can look at this.

@juliev0
Copy link
Contributor

juliev0 commented Feb 3, 2022

PR here: #1585

@whynowy whynowy closed this as completed Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juliev0 juliev0

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@whynowy @juliev0