Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] [Resource Gateway] Replace Labels and Annotations in ResourceFilter with LabelSelector #358

Closed
logicfox opened this issue Sep 24, 2019 · 1 comment · Fixed by #571
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@logicfox
Copy link
Contributor

logicfox commented Sep 24, 2019

Is your feature request related to a problem? Please describe.
This is a feature request.
The Resource Filter config in Resource Gateways currently supports Labels and Annotations, but these filters require specifying a value. Enhancing this with the Label Selector would allow for more fine grained definition of selectors.

Describe the solution you'd like
Replace Labels and Annotations in ResourceFilter with LabelSelector or have it in addition to the current options.

Describe alternatives you've considered
No alternatives available

Additional context
I have a case where I want to execute a workflow if a certain label exists in a Namespace. The value for this label differs. With the current set of options, I have to have multiple configuration blocks for each label value.

This would also imply that there would be lesser code to maintain.

@VaibhavPage
Copy link
Contributor

Cool, I'll add it.

@VaibhavPage VaibhavPage self-assigned this Oct 5, 2019
@VaibhavPage VaibhavPage added the enhancement New feature or request label Oct 5, 2019
@VaibhavPage VaibhavPage added this to the v0.13 milestone Jan 28, 2020
@VaibhavPage VaibhavPage modified the milestones: v0.13, v0.14.0 Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants