Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource Event Reprocesses 'Events' and Doesn't Support Annotation Filters #560

Closed
bpayt2 opened this issue Mar 22, 2020 · 18 comments · Fixed by #571
Closed

Resource Event Reprocesses 'Events' and Doesn't Support Annotation Filters #560

bpayt2 opened this issue Mar 22, 2020 · 18 comments · Fixed by #571

Comments

@bpayt2
Copy link

bpayt2 commented Mar 22, 2020

The resource event source type is performing a list operation for a particular resources within Kubernetes. This is not an 'event/trigger' but just a continual list. I am reprocessing the same resources continuously. Can you add support for only new resources?

Also, I am unable to filter on annotations.

@VaibhavPage
Copy link
Contributor

VaibhavPage commented Mar 22, 2020

Are you using v0.13.0? Take a look at the updated event-source for resource gateway at https://github.com/argoproj/argo-events/blob/master/examples/event-sources/resource.yaml . The type is renamed to eventType.

The resource gateway runs a shared informer for events (Add, Update and Delete) and doesn't just list objects in a for-loop. If you want to listen to new objects, then you need to specify the correct eventType(ADD, UPDATE or DELETE). You can add filters on labels to narrow the list of objects you want to monitor.

To listen to new objects. specify eventType as ADD.

The gateway does not process any object twice. It only processes objects notified to it by Kubernetes API server.

Annotations are not meant to be used for filtering purposes. They contain non-identifying information as specified in Kubernetes guidelines. Besides K8s Informer API does not allow to filter on annotations. If you still want to filter on annotations, I'd suggest using DataFilters in Sensor https://argoproj.github.io/argo-events/tutorials/07-filters/#data-filter.

There is a pr #561 to support a list of event types for resource gateway which will be available in next release.

@bpayt2
Copy link
Author

bpayt2 commented Mar 23, 2020

I am using eventType and Label filters; however, I am not getting the expected behavior.

Expected Behavior: Generate event each time a new AWS EBS persistentvolume is created.
Actual Behavior: A list of all EBS volumes is pulled when the event source is created. I am seeing duplicate processes. The label filter works; but the createdBy is historic and doesn't allow me to specify 'from this point on'. The request for Annotation filter is because I want to use system information within my selection; example: 'from this storage class provisioner'.

Data filters are not working with the Sensor because Kubernetes resource event data is base64 encoded - once decoded, the body is also encoded. I do not see where I can specify dataDecoded (for example): as a data filter within the sensor. This is preventing me from mapping event data to parameters as well.

############Event Source File###############
apiVersion: argoproj.io/v1alpha1
kind: EventSource
metadata:
name: resource-event-source
spec:
type: "resource"
resource:
example:
namespace: ""
group: ""
version: "v1"
resource: "persistentvolumes"
type: ADD
filter:
labels:
failure-domain.beta.kubernetes.io/region: "us-east-1"

@bpayt2
Copy link
Author

bpayt2 commented Mar 23, 2020

The reprocessing that is occurring also do to the base64 encoding issue. The eventType is within the data element that is encoded; so it is not filtering correctly. I am getting all updates, add, deletes.

@bpayt2
Copy link
Author

bpayt2 commented Mar 26, 2020

update?

@VaibhavPage
Copy link
Contributor

VaibhavPage commented Mar 28, 2020

Everything seems to work. Let's take an example,

  1. The resource gateway set up is available here

  2. The structure of the event is as follows,

    {
        "context": {
          "type": "type_of_gateway",
          "specVersion": "cloud_events_version",
          "source": "name_of_the_gateway",
          "eventID": "unique_event_id",
          "time": "event_time",
          "dataContentType": "type_of_data",
          "subject": "name_of_the_event_within_event_source"
        },
        "data": {
          "type": "type_of_the_event", // ADD, UPDATE or DELETE
          "body": "resource_body", // JSON format
          "group": "resource_group_name",
          "version": "resource_version_name",
          "resource": "resource_name"
        }
    }
  1. Let set up gateway to listen to CREATE events for workflow with label name: my-worfklow,
apiVersion: argoproj.io/v1alpha1
kind: EventSource
metadata:
  name: resource-event-source
spec:
  type: "resource"
  resource:
    example:
      # namespace to listen events within
      namespace: "argo-events"
      # resource group
      group: "argoproj.io"
      # resource version
      version: "v1alpha1"
      # resource kind
      resource: "workflows"
      # type of event
      # possible values are ADD, DELETE, UPDATE
      # Optional
      eventType: ADD
      # Filters to apply on watched object
      # Optional
      filter:
        labels:
          name: "my-workflow"

4.Set up the gateway

apiVersion: argoproj.io/v1alpha1
kind: Gateway
metadata:
  name: resource-gateway
  labels:
    # gateway controller with instanceId "argo-events" will process this gateway
    gateways.argoproj.io/gateway-controller-instanceid: argo-events
spec:
  type: resource
  eventSourceRef:
    name: resource-event-source
  template:
    metadata:
      name: resource-gateway
      labels:
        gateway-name: resource-gateway
    spec:
      containers:
        - name: gateway-client
          image: argoproj/gateway-client:v0.13.0
          imagePullPolicy: Always
          command: ["/bin/gateway-client"]
        - name: resource-events
          image: argoproj/resource-gateway:v0.13.0
          imagePullPolicy: Always
          command: ["/bin/resource-gateway"]
      serviceAccountName: argo-events-sa
  subscribers:
    http:
      - "http://resource-sensor.argo-events.svc:9300/"

  1. Create the sensor. Let's parameterize the triggered workflow with the name of the workflow which caused the event. I've added the data filter as well.

apiVersion: argoproj.io/v1alpha1
kind: Sensor
metadata:
  name: resource-sensor
  labels:
    sensors.argoproj.io/sensor-controller-instanceid: argo-events
spec:
  template:
    spec:
      containers:
        - name: sensor
          image: argoproj/sensor:v0.13.0
          imagePullPolicy: Always
      serviceAccountName: argo-events-sa
  subscription:
    http:
      port: 9300
  dependencies:
    - name: test-dep
      gatewayName: resource-gateway
      eventName: example
      filters:
        name: data-filter
        data:
          - path: body.metadata.name
            type: string
            value:
              - my-workflow
  triggers:
    - template:
        name: argo-workflow
        k8s:
          group: argoproj.io
          version: v1alpha1
          resource: workflows
          operation: create
          source:
            resource:
              apiVersion: argoproj.io/v1alpha1
              kind: Workflow
              metadata:
                generateName: resource-workflow-
              spec:
                entrypoint: whalesay
                arguments:
                  parameters:
                  - name: message
                    # the value will get overridden by the event payload from test-dep
                    value: hello world
                templates:
                - name: whalesay
                  inputs:
                    parameters:
                    - name: message
                  container:
                    image: docker/whalesay:latest
                    imagePullPolicy: IfNotPresent
                    command: [cowsay]
                    args: ["{{inputs.parameters.message}}"]
          parameters:
            - src:
                dependencyName: test-dep
                dataKey: body.metadata.name
              dest: spec.arguments.parameters.0.value

  1. Create the workflow my-workflow,
apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  name: my-workflow
  labels:
    name: my-workflow
spec:
  entrypoint: whalesay
  templates:
  - name: whalesay
    container:
      image: docker/whalesay:latest
      command: [cowsay]
      args: ["hello world"]
  1. Take a look at the trigger workflow resource-workflow-xxxxxx, it prints,

  | _____________
-- | --
  | < my-workflow >
  | -------------
  | \
  | \
  | \
  | ##        .
  | ## ## ##       ==
  | ## ## ## ##      ===
  | /""""""""""""""""___/ ===
  | ~~~ {~~ ~~~~ ~~~ ~~~~ ~~ ~ /  ===- ~~~
  | \______ o          __/
  | \    \        __/
  | \____\______/

  1. Change the data filters however you like to filter on annotations and other things...

  2. You can find more info on trigger parameterization at https://argoproj.github.io/argo-events/tutorials/02-parameterization/ and data filters at https://argoproj.github.io/argo-events/tutorials/07-filters/

@gordiustechnologies
Copy link

gordiustechnologies commented Mar 29, 2020

@VaibhavPage, I have the same problem. I am trying to react to node deletions using resource events and the eventType mechanism doesn't seem to be working. Not just deletions, but all node events seem to go through. Generated events look like:

{ 'context': { 'dataContentType': 'application/json',
               'id': '32373863653939352d333766332d343664612d386665322d623766363532643363393462',
               'source': 'resource-gateway',
               'specVersion': '0.3',
               'subject': 'node-delete',
               'time': '2020-03-29T02:58:57.420038Z',
               'type': 'resource'},
  'data': '{"type":"UPDATE","body":{"apiVersion":"v1","kind":"Node","metadata":{"annotations":{"kubeadm.alpha.kubernetes.io/cri-socket":"/var/run/dockershim.sock","node.alpha.kubernetes.io/ttl":"0","projectcalico.org/IPv4Address":"172.32.240.160/18","projectcalico.org/IPv4IPIPTunnelAddr":"192.168.53.0","volumes.kubernetes.io/controller-managed-attach-detach":"true"},"creationTimestamp":"2020-03-29T02:56:53Z","labels":{"beta.kubernetes.io/arch":"amd64","beta.kubernetes.io/instance-type":"t3.xlarge","beta.kubernetes.io/os":"linux","failure-domain.beta.kubernetes.io/region":"us-west-2","failure-domain.beta.kubernetes.io/zone":"us-west-2d","kubernetes.io/arch":"amd64","kubernetes.io/hostname":"ip-172-32-240-160.us-west-2.compute.internal","kubernetes.io/os":"linux","node-role.kubernetes.io/master":""},"managedFields":[{"apiVersion":"v1","fieldsType":"FieldsV1","fieldsV1":{"f:metadata":{"f:labels":{"f:beta.kubernetes.io/instance-type":{},"f:failure-domain.beta.kubernetes.io/region":{},"f:failure-domain.beta.kubernetes.io/zone":{}}},"f:spec":{"f:providerID":{},"f:taints":{}},"f:status":{"f:addresses":{"k:{\"type\":\"ExternalDNS\"}":{".":{},"f:address":{},"f:type":{}},"k:{\"type\":\"ExternalIP\"}":{".":{},"f:address":{},"f:type":{}},"k:{\"type\":\"InternalDNS\"}":{".":{},"f:address":{},"f:type":{}}}}},"manager":"cloud-controller-manager","operation":"Update","time":"2020-03-29T02:57:51Z"},{"apiVersion":"v1","fieldsType":"FieldsV1","fieldsV1":{"f:status":{"f:conditions":{"k:{\"type\":\"DiskPressure\"}":{"f:lastHeartbeatTime":{}},"k:{\"type\":\"MemoryPressure\"}":{"f:lastHeartbeatTime":{}},"k:{\"type\":\"PIDPressure\"}":{"f:lastHeartbeatTime":{}},"k:{\"type\":\"Ready\"}":{"f:lastHeartbeatTime":{}}},"f:images":{}}},"manager":"kubelet","operation":"Update","time":"2020-03-29T02:58:57Z"}],"name":"ip-172-32-240-160.us-west-2.compute.internal","resourceVersion":"1145","selfLink":"/api/v1/nodes/ip-172-32-240-160.us-west-2.compute.internal","uid":"bfc42daf-072f-44a3-84b6-c1aef3234b1c"},"spec":{"podCIDR":"192.168.0.0/24","podCIDRs":["192.168.0.0/24"],"providerID":"aws:///us-west-2d/i-0e025154a231dad4d","taints":[{"effect":"NoSchedule","key":"node-role.kubernetes.io/master"}]},"status":{"addresses":[{"address":"172.32.240.160","type":"InternalIP"},{"address":"44.229.31.70","type":"ExternalIP"},{"address":"ip-172-32-240-160.us-west-2.compute.internal","type":"InternalDNS"},{"address":"ip-172-32-240-160.us-west-2.compute.internal","type":"Hostname"},{"address":"ec2-44-229-31-70.us-west-2.compute.amazonaws.com","type":"ExternalDNS"}],"allocatable":{"cpu":"4","ephemeral-storage":"7430289396","hugepages-1Gi":"0","hugepages-2Mi":"0","memory":"15759Mi","pods":"110"},"capacity":{"cpu":"4","ephemeral-storage":"8062380Ki","hugepages-1Gi":"0","hugepages-2Mi":"0","memory":"15859Mi","pods":"110"},"conditions":[{"lastHeartbeatTime":"2020-03-29T02:57:40Z","lastTransitionTime":"2020-03-29T02:57:40Z","message":"Calico is running on this node","reason":"CalicoIsUp","status":"False","type":"NetworkUnavailable"},{"lastHeartbeatTime":"2020-03-29T02:58:57Z","lastTransitionTime":"2020-03-29T02:56:53Z","message":"kubelet has sufficient memory available","reason":"KubeletHasSufficientMemory","status":"False","type":"MemoryPressure"},{"lastHeartbeatTime":"2020-03-29T02:58:57Z","lastTransitionTime":"2020-03-29T02:56:53Z","message":"kubelet has no disk pressure","reason":"KubeletHasNoDiskPressure","status":"False","type":"DiskPressure"},{"lastHeartbeatTime":"2020-03-29T02:58:57Z","lastTransitionTime":"2020-03-29T02:56:53Z","message":"kubelet has sufficient PID available","reason":"KubeletHasSufficientPID","status":"False","type":"PIDPressure"},{"lastHeartbeatTime":"2020-03-29T02:58:57Z","lastTransitionTime":"2020-03-29T02:57:37Z","message":"kubelet is posting ready status. AppArmor enabled","reason":"KubeletReady","status":"True","type":"Ready"}],"daemonEndpoints":{"kubeletEndpoint":{"Port":10250}},"images":[{"names":["argoproj/sensor@sha256:35a19919a49da1db0a238bd1a6eee3163814d763c4a3a62de1e73f719130fa46","argoproj/sensor:v0.13.0"],"sizeBytes":483148634},{"names":["argoproj/argoexec@sha256:3bbec3eb7c01d6747e9bfcd8b6f583ca379cb0efca8bbe226aa22863a990bf1d","argoproj/argoexec:v2.7.0-rc3"],"sizeBytes":298482658},{"names":["gordius/k8s-aws@sha256:b8b56e9e54a2c2c36c84b84a4a8ad87e135b2e4cd2950c780c432599b0ad17cc","gordius/k8s-aws:latest"],"sizeBytes":294841739},{"names":["k8s.gcr.io/etcd@sha256:4afb99b4690b418ffc2ceb67e1a17376457e441c1f09ab55447f0aaf992fa646","k8s.gcr.io/etcd:3.4.3-0"],"sizeBytes":288426917},{"names":["calico/node@sha256:887bcd551668cccae1fbfd6d2eb0f635ec37bb4cf599e1169989aa49dfac5b57","calico/node:v3.11.2"],"sizeBytes":255343962},{"names":["argoproj/gateway-client@sha256:8b6c71d085564f6163af5a99235912f5ba67e4b5998e95e530481076e2970d05","argoproj/gateway-client:v0.13.0"],"sizeBytes":248239878},{"names":["argoproj/sensor-controller@sha256:fde3166c6557e2ef12ec7494c2f9962c42855c7b9d07d33c9a677a2a5832474f","argoproj/sensor-controller:v0.13.0"],"sizeBytes":243671385},{"names":["argoproj/gateway-controller@sha256:59c59b67a8ea3b80eb1423095d8980037d1d68f9b49e9d91ad691a7e018a1068","argoproj/gateway-controller:v0.13.0"],"sizeBytes":243269159},{"names":["calico/cni@sha256:f5808401a96ba93010b9693019496d88070dde80dda6976d10bc4328f1f18f4e","calico/cni:v3.11.2"],"sizeBytes":204185753},{"names":["k8s.gcr.io/kube-apiserver@sha256:fc4efb55c2a7d4e7b9a858c67e24f00e739df4ef5082500c2b60ea0903f18248","k8s.gcr.io/kube-apiserver:v1.18.0"],"sizeBytes":172964371},{"names":["k8s.gcr.io/kube-controller-manager@sha256:d926b172b8fc3568d8eab9736b2f79a1afefcb809d030dd4465cbb0d444ce293","k8s.gcr.io/kube-controller-manager:v1.18.0"],"sizeBytes":162368019},{"names":["k8s.gcr.io/cloud-controller-manager@sha256:859826c34e1551e7151abc86fb3286eddc2eb53e697c8594e2e39f1366a616e3","k8s.gcr.io/cloud-controller-manager:v1.15.11"],"sizeBytes":143011569},{"names":["k8s.gcr.io/kube-proxy@sha256:9e858386d52d0abaf936c1d10a763648ab7d85c8eb0af08a50a64238146e5571","k8s.gcr.io/kube-proxy:v1.18.0"],"sizeBytes":116534263},{"names":["calico/pod2daemon-flexvol@sha256:93c64d6e3e0a0dc75d1b21974db05d28ef2162bd916b00ce62a39fd23594f810","calico/pod2daemon-flexvol:v3.11.2"],"sizeBytes":111122324},{"names":["k8s.gcr.io/kube-scheduler@sha256:33063bc856e99d12b9cb30aab1c1c755ecd458d5bd130270da7c51c70ca10cf6","k8s.gcr.io/kube-scheduler:v1.18.0"],"sizeBytes":95275539},{"names":["argoproj/argocli@sha256:91ba657c923fc9bd5a1e5a4fefff12a56af241d23e2bb33461d927eb6132f10a","argoproj/argocli:v2.7.0-rc3"],"sizeBytes":68417309},{"names":["calico/kube-controllers@sha256:1169cca40b489271714cb1e97fed9b6b198aabdca1a1cc61698dd73ee6703d60","calico/kube-controllers:v3.11.2"],"sizeBytes":52477980},{"names":["argoproj/workflow-controller@sha256:c6efd4941aaf11281dc4b40839b19e902573cc229cfcdefb67058b34fa90be6f","argoproj/workflow-controller:v2.7.0-rc3"],"sizeBytes":50332040},{"names":["argoproj/resource-gateway@sha256:3b0276a255ec25e9a80a9c8bf16abd8f78292fbcd706fecb043ba476b7abfaa0","argoproj/resource-gateway:v0.13.0"],"sizeBytes":45555144},{"names":["k8s.gcr.io/coredns@sha256:2c8d61c46f484d881db43b34d13ca47a269336e576c81cf007ca740fa9ec0800","k8s.gcr.io/coredns:1.6.7"],"sizeBytes":43794147},{"names":["k8s.gcr.io/pause@sha256:927d98197ec1141a368550822d18fa1c60bdae27b78b0c004f705f548c07814f","k8s.gcr.io/pause:3.2"],"sizeBytes":682696}],"nodeInfo":{"architecture":"amd64","bootID":"d5a99c5d-8135-481d-9773-f1619bf5662f","containerRuntimeVersion":"docker://19.3.8","kernelVersion":"4.19.0-8-cloud-amd64","kubeProxyVersion":"v1.18.0","kubeletVersion":"v1.18.0","machineID":"a03f778952dd493189ff3d8018ce2b5d","operatingSystem":"linux","osImage":"Debian GNU/Linux 10 (buster)","systemUUID":"ec2957b6-b856-6b74-a955-5eceb77a7e91"}}},"group":"","version":"v1","resource":"nodes"}'}

Note that this does not look like the example you gave: The data entry is not a dictionary, it is an encoded string (just like @bpayt2 observed). Could this be the cause of the issue?
For completeness, here is my event source:

apiVersion: argoproj.io/v1alpha1
kind: EventSource
metadata:
  name: resource-event-source
spec:
  type: resource
  resource:
    node-delete:
      group: ""
      version: v1
      resource: nodes
      eventType: DELETE

@ozankabak
Copy link

This is a continuation of the post above (coming from the same team). For now, we use a data filter in the sensor as a workaround to weed out non-delete events. The data filter looks like this:

...
dependencies:
  - name: resource-gateway-node-delete
    gatewayName: resource-gateway
    eventName: node-delete
    # # # WORKAROUND # # #
    filters:
      name: type-filter
      data:
        - path: type
          type: string
          value:
            - DELETE
...

@bpayt2
Copy link
Author

bpayt2 commented Mar 30, 2020

@ozankabak @gordiustechnologies Appreciate the second observation - I have tested your workaround and it does permit the filtering on event type (at the secondary level; event sensor). Thank you very much!

@VaibhavPage Understanding that it is not desirable to implement event type filtering within the event sensor and that we are still unable to leverage data filters within the event sensor, can you add this as an enhancement request? To reiterate; it would be desired to have a base64 decode option for event source's resource type and event sensors' filter.

@VaibhavPage
Copy link
Contributor

@gordiustechnologies Although the event data is base64 encoded when you use the parameters or filters, the sensor internally decodes the event data into a JSON format like following,

"data": {
          "type": "type_of_the_event", // ADD, UPDATE or DELETE
          "body": "resource_body", // JSON format
          "group": "resource_group_name",
          "version": "resource_version_name",
          "resource": "resource_name"
        }

The body is also base64 encode, but once you refer it in the sensor as I have done in the filter posted above, it decodes it into JSON format of the corresponding K8s object,

      filters:
        name: data-filter
        data:
          - path: body.metadata.name
            type: string
            value:
              - my-workflow

Node events of all types going through gateway should not be related to the event body being base64 encoded. I'll try to replicate it on my setup and check if there is an issue with node events.

@bpayt2 maybe I am not able to understand the problem, can you post your gateway, sensor and event source file and walk me through the desired outcome? It'll help me test on my local setup. Thanks!!

@ozankabak
Copy link

Thanks @VaibhavPage. Considering @bpayt2's posts, I suspect the event type filtering issue is not specific to nodes, but possibly affecting other resources too. Encoding may not be the root cause, but something is definitely interfering with the eventType filtering mechanism.

@VaibhavPage
Copy link
Contributor

VaibhavPage commented Mar 30, 2020

Got it. I have a pr #561 which will fix the issue if any. I'll keep you guys posted.

@ozankabak
Copy link

@VaibhavPage, can you make a 0.13.1 release so that we can verify whether eventType filtering works after this fix in our setups?

@VaibhavPage VaibhavPage reopened this Apr 1, 2020
@VaibhavPage
Copy link
Contributor

I'll cut a release in couple of days.

@ozankabak
Copy link

@VaibhavPage Does 0.14 fix this? Should we try it out in our setups?

@VaibhavPage
Copy link
Contributor

VaibhavPage commented Apr 13, 2020

@VaibhavPage
Copy link
Contributor

@ozankabak did it fix the issue?

@bpayt2
Copy link
Author

bpayt2 commented May 6, 2020

@VaibhavPage @ozankabak I have tested the latest and it fixes my reported issue. Please feel free to close. Thank you!

@bpayt2 bpayt2 closed this as completed May 6, 2020
@ozankabak
Copy link

@VaibhavPage: I can confirm that it works too. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants