Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[argo-rollouts] crd issue #604

Closed
olfway opened this issue Mar 2, 2021 · 1 comment · Fixed by #709
Closed

[argo-rollouts] crd issue #604

olfway opened this issue Mar 2, 2021 · 1 comment · Fixed by #709
Labels
bug Something isn't working no-issue-activity

Comments

@olfway
Copy link

olfway commented Mar 2, 2021

Describe the bug
Currently, argo-rollouts helm chart uses its own crds, different from the ones in argo-rollouts repo

For example rollout-crd.yaml:
In helm chart it has "apiextensions.k8s.io/v1" and it seems field pruning is enabled, because spec.preserveUnknownFields is not defined

But some deployment fields are not declared in the rollout object, for example:

template.spec.containers:
  resources:
    type: object

Because of this, it's not possible to set requests and limits for a deployment, Kubernetes ignore and doesn't persist them

To Reproduce
Steps to reproduce the behavior:

  1. Install argo-rollouts crd with helm chart
  2. Create rollout object with requests or limits for pods
  3. Get rollout object from k8s
  4. See resources field is empty

Expected behavior
CRDs should contain all possible fields or have fields pruning disabled

Additional context
https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/#field-pruning

Manifest from https://github.com/argoproj/argo-rollouts/blob/master/manifests/crds/rollout-crd.yaml has the same resources declaration but it is uses apiextensions.k8s.io/v1beta1

@olfway olfway added the bug Something isn't working label Mar 2, 2021
@github-actions
Copy link

github-actions bot commented May 2, 2021

Stale issue message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working no-issue-activity
Projects
None yet
1 participant