You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Currently, argo-rollouts helm chart uses its own crds, different from the ones in argo-rollouts repo
For example rollout-crd.yaml:
In helm chart it has "apiextensions.k8s.io/v1" and it seems field pruning is enabled, because spec.preserveUnknownFields is not defined
But some deployment fields are not declared in the rollout object, for example:
template.spec.containers:
resources:
type: object
Because of this, it's not possible to set requests and limits for a deployment, Kubernetes ignore and doesn't persist them
To Reproduce
Steps to reproduce the behavior:
Install argo-rollouts crd with helm chart
Create rollout object with requests or limits for pods
Get rollout object from k8s
See resources field is empty
Expected behavior
CRDs should contain all possible fields or have fields pruning disabled
Describe the bug
Currently, argo-rollouts helm chart uses its own crds, different from the ones in argo-rollouts repo
For example rollout-crd.yaml:
In helm chart it has "apiextensions.k8s.io/v1" and it seems field pruning is enabled, because spec.preserveUnknownFields is not defined
But some deployment fields are not declared in the rollout object, for example:
Because of this, it's not possible to set requests and limits for a deployment, Kubernetes ignore and doesn't persist them
To Reproduce
Steps to reproduce the behavior:
Expected behavior
CRDs should contain all possible fields or have fields pruning disabled
Additional context
https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/#field-pruning
Manifest from https://github.com/argoproj/argo-rollouts/blob/master/manifests/crds/rollout-crd.yaml has the same resources declaration but it is uses apiextensions.k8s.io/v1beta1
The text was updated successfully, but these errors were encountered: