Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/apiclient/apiclient.go missing #2815

Open
JuozasVainauskas opened this issue May 29, 2023 Discussed in #2799 · 2 comments
Open

pkg/apiclient/apiclient.go missing #2815

JuozasVainauskas opened this issue May 29, 2023 Discussed in #2799 · 2 comments

Comments

@JuozasVainauskas
Copy link

JuozasVainauskas commented May 29, 2023

Discussed in #2799

Originally posted by JuozasVainauskas May 22, 2023
Hello,

I want to use argo-rollout apiClient to interact with argo-rollouts resources from my Golang application (in this case, promote rollout in certain scenarios). However, I am not entirely sure how to use argo-rollouts apiClient.

For example, in ArgoCD and argo-workflows cases I am able to use pkg/apiclient/apiclient.go to create clients for particular resources (e.g. ApplicationClient, WorkflowServiceClient, etc.)

In argo-rollouts case, I want to create RolloutServiceClient. However, pkg/apiclient/apiclient.go file for creation of the client is not present in the package. I assume that this file should be available in the package and that this is a bug (If this is the case, I will create an issue). However, if I am mistaken and it is indeed intentional, how should I create a RolloutServiceClient?

As described in the discussion above, I want to user argo-rollouts apiClient. However, I think that pkg/apiclient/apiclient.go is missing. I assume that it was forgotten to be included in this PR: #1015

@zachaller
Copy link
Collaborator

zachaller commented May 30, 2023

@JuozasVainauskas argo rollouts does not have an api, it just uses the k8s api to modify particular fields on the rollouts spec. You can look at what the cli is currently doing to get an understanding of what to modify such as promote

@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants