From 83ade435b8414ecb1c252dbab0efab9d6de6fcbe Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Greg=20Berg=C3=A9?= <berge.greg@gmail.com>
Date: Sun, 1 Apr 2018 16:22:09 +0000
Subject: [PATCH] fix(expect-puppeteer): reduce chance of collision

Relative to https://github.com/smooth-code/jest-puppeteer/issues/17\#issuecomment-377698539
---
 package.json                                |  4 ++--
 packages/expect-puppeteer/src/index.test.js |  2 ++
 packages/expect-puppeteer/src/utils.js      |  1 +
 yarn.lock                                   | 20 ++++++++++----------
 4 files changed, 15 insertions(+), 12 deletions(-)

diff --git a/package.json b/package.json
index 94a5240c..a3096883 100644
--- a/package.json
+++ b/package.json
@@ -20,10 +20,10 @@
     "eslint": "^4.19.1",
     "eslint-config-airbnb-base": "^12.1.0",
     "eslint-config-prettier": "^2.9.0",
-    "eslint-plugin-import": "^2.9.0",
+    "eslint-plugin-import": "^2.10.0",
     "express": "^4.16.3",
     "jest": "^22.4.3",
-    "lerna": "^2.9.0",
+    "lerna": "^2.9.1",
     "puppeteer": "^1.2.0",
     "standard-version": "^4.3.0"
   }
diff --git a/packages/expect-puppeteer/src/index.test.js b/packages/expect-puppeteer/src/index.test.js
index 78cf6236..fd0b5aff 100644
--- a/packages/expect-puppeteer/src/index.test.js
+++ b/packages/expect-puppeteer/src/index.test.js
@@ -10,5 +10,7 @@ describe('expect-puppeteer', () => {
     const main = await page.$('main')
     expect(main).toBeDefined()
     expect(main).not.toBe(null)
+
+    expect(200).toBe(200)
   })
 })
diff --git a/packages/expect-puppeteer/src/utils.js b/packages/expect-puppeteer/src/utils.js
index 4b7d0720..3ccd2ca9 100644
--- a/packages/expect-puppeteer/src/utils.js
+++ b/packages/expect-puppeteer/src/utils.js
@@ -10,6 +10,7 @@ export const getPuppeteerType = instance => {
     instance &&
     instance.constructor &&
     instance.constructor.name &&
+    ['Page', 'ElementHandle'].includes(instance.constructor.name) &&
     instance.$
   ) {
     return instance.constructor.name
diff --git a/yarn.lock b/yarn.lock
index d64ea5f8..e46e13d8 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -1678,23 +1678,23 @@ eslint-import-resolver-node@^0.3.1:
     debug "^2.6.9"
     resolve "^1.5.0"
 
-eslint-module-utils@^2.1.1:
-  version "2.1.1"
-  resolved "https://registry.yarnpkg.com/eslint-module-utils/-/eslint-module-utils-2.1.1.tgz#abaec824177613b8a95b299639e1b6facf473449"
+eslint-module-utils@^2.2.0:
+  version "2.2.0"
+  resolved "https://registry.yarnpkg.com/eslint-module-utils/-/eslint-module-utils-2.2.0.tgz#b270362cd88b1a48ad308976ce7fa54e98411746"
   dependencies:
     debug "^2.6.8"
     pkg-dir "^1.0.0"
 
-eslint-plugin-import@^2.9.0:
-  version "2.9.0"
-  resolved "https://registry.yarnpkg.com/eslint-plugin-import/-/eslint-plugin-import-2.9.0.tgz#26002efbfca5989b7288ac047508bd24f217b169"
+eslint-plugin-import@^2.10.0:
+  version "2.10.0"
+  resolved "https://registry.yarnpkg.com/eslint-plugin-import/-/eslint-plugin-import-2.10.0.tgz#fa09083d5a75288df9c6c7d09fe12255985655e7"
   dependencies:
     builtin-modules "^1.1.1"
     contains-path "^0.1.0"
     debug "^2.6.8"
     doctrine "1.5.0"
     eslint-import-resolver-node "^0.3.1"
-    eslint-module-utils "^2.1.1"
+    eslint-module-utils "^2.2.0"
     has "^1.0.1"
     lodash "^4.17.4"
     minimatch "^3.0.3"
@@ -3259,9 +3259,9 @@ left-pad@^1.2.0:
   version "1.2.0"
   resolved "https://registry.yarnpkg.com/left-pad/-/left-pad-1.2.0.tgz#d30a73c6b8201d8f7d8e7956ba9616087a68e0ee"
 
-lerna@^2.9.0:
-  version "2.9.0"
-  resolved "https://registry.yarnpkg.com/lerna/-/lerna-2.9.0.tgz#303f70bc50b1c4541bdcf54eda13c36fe54401f3"
+lerna@^2.9.1:
+  version "2.9.1"
+  resolved "https://registry.yarnpkg.com/lerna/-/lerna-2.9.1.tgz#d7d21793ad35ae7733733ced34ce30f5b3bb1abe"
   dependencies:
     async "^1.5.0"
     chalk "^2.1.0"