-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visual regression? expect(page).toMatchScreenshot()
?
#252
Comments
Yeah it would be great, but we have to couple it to a services. Storing screenshots in the repository is not always a good solution. Also flakiness could be very problematic. It is better to rely on a third party service like Argos. |
I think it would make sense to just let it store the screenshots locally, then they can be uploaded/downloaded by the consumer the way they prefer. |
If it is like that, it is just screenshot and it is already possible using Puppeteer isn't it? |
You can take screenshots but there is no logic in place do perform the comparison |
Yeah but to compare we have to access previous screenshots 😅 |
Yeah I'm just proposing to leave the screenshots in the filesystem/git, and let the user do whatever they want with them. One could have a workflow like the following:
|
🚀 Feature Proposal
I't be great to have a
toMatchSnapshot()
like API for visual regression tests.Motivation
There are cases where visual regression is very useful.
Example
Pitch
It belongs to jest-puppeteer because it's a Jest-like API to take advantage of a Puppeteer feature.
The text was updated successfully, but these errors were encountered: