Webpage.uploadFile not working in phantomjs 2.0 #12506

loduis · 2014-08-26T20:27:03Z

This is in linux (Ubuntu)

var
  page     = require('webpage').create(),
  filename = '/media/loduis/DATOS/projects/ghostdriver/test/javascript/local.jpg';



page.onFilePicker = function(oldFile) {

  console.log('Listen event.');

  return filename;
};


page.open('data:text/html,' +
  '<body><form method="POST" enctype="multipart/form-data">' +
  'File to upload: <input type="file" name="upfile" style="width: 200px;height: 100px; background: gray">' +
  '</form></body>', function(status) {

  console.log(status);
  page.uploadFile('input[name=upfile]', filename);

  page.render('test.png');
});

The result on phantomjs 1.9.7 is

while 2.0 is

another important thing is that it is never fired onFilePicker

ariya · 2014-08-27T03:21:29Z

This is a known regression.

burkestar · 2014-11-04T17:01:45Z

What is causing this issue? I'd like to contribute a fix but not sure where to start.

burkestar · 2014-11-04T19:23:49Z

Looks like I was able to track down the cause of the regression issue and I found a suitable workaround (although I'm not sure its the proper fix long-term).

Basically, a change made in Qt 4.8 and incorporated subsequently in Qt 5.0 prevented clicking on file input elements that were not caused by user gestures.

The following patch to comment out the 2 relevant lines in src/qt/qtwebkit/Source/WebCore/html/FileInputType.cpp circumvents that and allows file uploads to work with Phantom 2. I was able to comment those 2 lines and rebuilding Phantom 2 from source.

diff --git a/src/qt/qtwebkit/Source/WebCore/html/FileInputType.cpp b/src/qt/qtwebkit/Source/WebCore/html/FileInputType.cpp
index 7362f63..1a7b148 100644
--- a/src/qt/qtwebkit/Source/WebCore/html/FileInputType.cpp
+++ b/src/qt/qtwebkit/Source/WebCore/html/FileInputType.cpp
@@ -187,8 +187,9 @@ void FileInputType::handleDOMActivateEvent(Event* event)
     if (element()->isDisabledFormControl())
         return;

-    if (!ScriptController::processingUserGesture())
-        return;
+    // PATCH related to #12506 - commented out to allow programmatic form file uploads
+    //if (!ScriptController::processingUserGesture())
+    //    return;

     if (Chrome* chrome = this->chrome()) {
         FileChooserSettings settings;

Here's the bug that tipped me off to the underlying cause. Originally the filtering of clicks for user gestures was done in Source/WebCore/rendering/RenderFIleUploadControl.cpp in the ::click() method but this revision refactored that functionality out and put in FileInputType.cpp.

Since this is a patch, I'm not sure how such things should be handled long-term (i.e. to ensure the patch is re-applied with newer updates to QtWebKit pulled into this repository).

loduis · 2014-11-05T14:55:09Z

Yes burkestar this works.

I also recompile from the source code

Thanks.

fixes issue ariya#12506 ariya#12506 Since phantomJS is a headless browser, evaluating if the gesture comes from a user is pointless. The UserGestureIndicator is now a dummy class that always returns true.

SpenserJ · 2015-01-22T02:52:23Z

This has solved the issue for me as well. Thank you @burkestar 👍

mhoran · 2015-02-04T03:24:34Z

It would be great to get a fix for this rolled into upstream Qt. We had originally filed a bug in WebKit here: https://bugs.webkit.org/show_bug.cgi?id=75385. It was closed when all Qt related bugs were bulk closed in the WebKit bug tracker.

In capybara-webkit, we work around this by using native clicks to submit file uploads.

xaviershay · 2015-02-17T02:17:14Z

fwiw, poltergeist spec showing the error if anyone was looking for a cheap way to repro: teampoltergeist/poltergeist#585

dmitryrechkin · 2015-03-04T05:17:36Z

I've tried javascript code example from this issue in phantomjs 2 which is published on your website and upload file is not working. Was it fixed at all?

see bug: ariya/phantomjs#12506

Nek- · 2015-03-25T10:29:01Z

The patch worked for me ! I can now upload via webdriver !

Thank you @burkestar

vassilevsky · 2015-03-27T15:33:01Z

Works for me too. Thanks @burkestar!

xaviershay · 2015-04-11T00:00:27Z

Just updating that this isn't fixed in the latest version installed by brew.

Seems like we need to patch QT upstream? https://bugs.webkit.org/show_bug.cgi?id=75385 doesn't necessarily seem appropriate, since it was file in 2012 and this issue only just surfaced?

stevepm · 2015-05-08T17:10:15Z

Have there been any updates to fix this besides the patch?

leeight · 2015-05-27T11:59:01Z

👍

leeight · 2015-05-27T11:59:01Z

👍

stevepm · 2015-05-28T02:35:44Z

I forked and made the update and it works great for me if anyone wants to build the binary off of my fork: https://github.com/stevepm/phantomjs/tree/2.0

dmitryrechkin · 2015-05-28T04:49:57Z

Is it possible to merge your fix to the main repository? Which commit fixes this issue? Thanks

vitallium · 2015-05-28T06:12:39Z

Yes, 2.0.1 version will receive this fix

leopucci-zz · 2015-07-07T16:55:56Z

Hi @stevepm , do you have a windows binary of your fork? (https://github.com/stevepm/phantomjs/tree/2.0) Could you share it?
Thanks

skakri · 2015-07-07T20:51:30Z

I have Ubuntu/Arch/OSX binaries @ https://github.com/skakri/phantomjs/releases/tag/2.0.1-regression-12506 , if someone needs those.

leopucci-zz · 2015-07-07T21:09:49Z

Thanks @skakri, your build have the patch for upload file gesture 👍 i´ll try to build on the weekend.

skakri · 2015-07-07T21:26:31Z

@leopucci if you manage to build it on Windows x68_64, feel free to send me a link to binary @ [email protected]. I'll add it to downloads.

leopucci-zz · 2015-07-07T21:28:51Z

Ok! :) 🎱

astrosuf · 2015-07-16T23:19:05Z

Hey,

has a windows patch for the upload file bug been created? Could someone direct me to the patch this will be extremely helpful!

cantonic · 2015-07-17T03:18:40Z

I compiled a binary for ubuntu 12.04 64bit using the source from @skakri on https://github.com/skakri/phantomjs/releases/tag/2.0.1-regression-12506
The ubuntu binary in the repo threw an error when using it on TravisCI: phantomjs: error while loading shared libraries: libicui18n.so.52: cannot open shared object file: No such file or directory.

I have uploaded the binary on https://github.com/cantonic/phantomjs/releases/tag/2.0.1-regression-12506

leopucci-zz · 2015-07-17T16:37:54Z

Sorry i did not had time to compile for windows yet as i told.

samir-mahendra · 2015-07-17T23:17:08Z

@skakri Thanks for sharing the source. My colleague compiled it for windows, binary is on Dropbox here: https://www.dropbox.com/s/u71vipap8bnm72u/windows-x86_64-phantomjs.exe?dl=0

skakri · 2015-07-18T12:39:33Z

@samir-mahendra – thanks, added. @cantonic sorry, I've compiled it for Ubuntu 14.04.

astrosuf · 2015-07-19T23:28:19Z

@samir-mahendra Thanks!!

geminiyellow · 2015-07-31T09:14:54Z

still not working.

samir-mahendra · 2015-07-31T17:09:25Z

@geminiyellow Can you give more details on which OS you are using, and the specific test that fails for you? The test script I used to test if it's working is below. You have to run it as follows:

phantomjs --ssl-protocol=any testscript.js

You can then check if the file got uploaded by going to: https://encodable.com/uploaddemo/?action=listfiles

// testscript.js
var webpage = require('webpage'),
system = require('system'),
fname;

if (system.args.length !== 2) {
    console.log('Usage: uploadtest.js filename');
    phantom.exit(1);
} else {
    fname = system.args[1];
    var page = webpage.create();

    page.onConsoleMessage = function(msg) {
        console.log(msg);
    };

    page.open("https://encodable.com/uploaddemo/", function (status) {
        console.log("Page opened, ready to upload file.  Status is", status);
        page.uploadFile('input[name=uploadname1]', fname);
        page.evaluate(function () {
            document.forms[0].submit();
        });
        window.setTimeout(function () {
            phantom.exit();
        }, 3000);
    });
}

nottoseethesun · 2015-08-01T01:00:48Z

+1

skakri · 2015-08-04T14:00:28Z

Please stop spamming "+1", it adds clutter.

vitallium · 2015-08-04T14:03:40Z

We have a proposal fix for this issue. And it will be landed in 2.0.1. Thanks for your patience.

vitallium · 2015-12-12T12:36:39Z

Fixed in master.

ariya added the Regression label Aug 27, 2014

vitallium added the help wanted label Dec 30, 2014

Drahakar mentioned this issue Jan 24, 2015

Deactivate UserGestureIndicator #12896

Closed

ariya mentioned this issue Jan 27, 2015

Problem with page.uploadFile #12914

Closed

PhilT mentioned this issue Feb 3, 2015

PhantomJS 2.0 Landed teampoltergeist/poltergeist#574

Closed

Drahakar mentioned this issue Feb 17, 2015

2.0.0 regression in file uploading #13000

Closed

parndt mentioned this issue Mar 2, 2015

Add support for PhantomJS 2.0 travis-ci/travis-ci#3225

Closed

asolntsev added a commit to selenide/selenide that referenced this issue Mar 4, 2015

file upload is broken in PhantomJS 2.0

2451e7d

see bug: ariya/phantomjs#12506

asolntsev added a commit to selenide/selenide that referenced this issue Mar 4, 2015

file upload is broken in PhantomJS 2.0

fea60d2

see bug: ariya/phantomjs#12506

route mentioned this issue Mar 16, 2015

attach_file doesn't attach the file teampoltergeist/poltergeist#594

Closed

pjg mentioned this issue Mar 29, 2015

phantomjs 2.0 cannot attach file with js: true teampoltergeist/poltergeist#596

Closed

lifeboatpres mentioned this issue May 22, 2015

Static build complication on Linux due to OpenSSL and ICU #12948

Closed

vitallium added 2.0 Regression and removed old.help-wanted labels Jun 9, 2015

vitallium added this to the Release 2.0.1 milestone Jun 9, 2015

johnnliu mentioned this issue Jul 24, 2015

File upload fails for PhantomJS 2.0.0 #13426

Closed

Repository owner locked and limited conversation to collaborators Aug 4, 2015

vitallium closed this as completed Dec 12, 2015

zackw modified the milestones: Release 2.0.1, Release 2.1 Dec 23, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Webpage.uploadFile not working in phantomjs 2.0 #12506

Webpage.uploadFile not working in phantomjs 2.0 #12506

loduis commented Aug 26, 2014

ariya commented Aug 27, 2014

burkestar commented Nov 4, 2014

burkestar commented Nov 4, 2014

loduis commented Nov 5, 2014

SpenserJ commented Jan 22, 2015

mhoran commented Feb 4, 2015

xaviershay commented Feb 17, 2015

dmitryrechkin commented Mar 4, 2015

Nek- commented Mar 25, 2015

vassilevsky commented Mar 27, 2015

xaviershay commented Apr 11, 2015

stevepm commented May 8, 2015

leeight commented May 27, 2015

leeight commented May 27, 2015

stevepm commented May 28, 2015

dmitryrechkin commented May 28, 2015

vitallium commented May 28, 2015

leopucci-zz commented Jul 7, 2015

skakri commented Jul 7, 2015

leopucci-zz commented Jul 7, 2015

skakri commented Jul 7, 2015

leopucci-zz commented Jul 7, 2015

astrosuf commented Jul 16, 2015

cantonic commented Jul 17, 2015

leopucci-zz commented Jul 17, 2015

samir-mahendra commented Jul 17, 2015

skakri commented Jul 18, 2015

astrosuf commented Jul 19, 2015

geminiyellow commented Jul 31, 2015

samir-mahendra commented Jul 31, 2015

nottoseethesun commented Aug 1, 2015

skakri commented Aug 4, 2015

vitallium commented Aug 4, 2015

vitallium commented Dec 12, 2015

Webpage.uploadFile not working in phantomjs 2.0 #12506

Webpage.uploadFile not working in phantomjs 2.0 #12506

Comments

loduis commented Aug 26, 2014

ariya commented Aug 27, 2014

burkestar commented Nov 4, 2014

burkestar commented Nov 4, 2014

loduis commented Nov 5, 2014

SpenserJ commented Jan 22, 2015

mhoran commented Feb 4, 2015

xaviershay commented Feb 17, 2015

dmitryrechkin commented Mar 4, 2015

Nek- commented Mar 25, 2015

vassilevsky commented Mar 27, 2015

xaviershay commented Apr 11, 2015

stevepm commented May 8, 2015

leeight commented May 27, 2015

leeight commented May 27, 2015

stevepm commented May 28, 2015

dmitryrechkin commented May 28, 2015

vitallium commented May 28, 2015

leopucci-zz commented Jul 7, 2015

skakri commented Jul 7, 2015

leopucci-zz commented Jul 7, 2015

skakri commented Jul 7, 2015

leopucci-zz commented Jul 7, 2015

astrosuf commented Jul 16, 2015

cantonic commented Jul 17, 2015

leopucci-zz commented Jul 17, 2015

samir-mahendra commented Jul 17, 2015

skakri commented Jul 18, 2015

astrosuf commented Jul 19, 2015

geminiyellow commented Jul 31, 2015

samir-mahendra commented Jul 31, 2015

nottoseethesun commented Aug 1, 2015

skakri commented Aug 4, 2015

vitallium commented Aug 4, 2015

vitallium commented Dec 12, 2015