From 09d310295f4d8efcb6febe594a5bec43470d6cbe Mon Sep 17 00:00:00 2001
From: mmagician <marcin.gorny.94@protonmail.com>
Date: Sun, 16 Oct 2022 20:59:20 +0200
Subject: [PATCH] if greatest is selected, second coordinate should be picked
 (#495)

Co-authored-by: Pratyush Mishra <pratyushmishra@berkeley.edu>
---
 ec/src/models/short_weierstrass/affine.rs | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/ec/src/models/short_weierstrass/affine.rs b/ec/src/models/short_weierstrass/affine.rs
index faceba456..b1340de3a 100644
--- a/ec/src/models/short_weierstrass/affine.rs
+++ b/ec/src/models/short_weierstrass/affine.rs
@@ -108,11 +108,11 @@ impl<P: SWCurveConfig> Affine<P> {
     /// largest y-coordinate be selected.
     #[allow(dead_code)]
     pub fn get_point_from_x_unchecked(x: P::BaseField, greatest: bool) -> Option<Self> {
-        Self::get_ys_from_x_unchecked(x).map(|(y, neg_y)| {
+        Self::get_ys_from_x_unchecked(x).map(|(smaller, larger)| {
             if greatest {
-                Self::new_unchecked(x, y)
+                Self::new_unchecked(x, larger)
             } else {
-                Self::new_unchecked(x, neg_y)
+                Self::new_unchecked(x, smaller)
             }
         })
     }