Add option to not automatically hook window.resize #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be useful to remove the responsibility to resizing from the fullcalendar control and instead have the developer manually trigger the required 'render' whenever /she/ deems that a resize happened. Consider cases where resize should only be triggered on a debounce because of complicated sizing code, or cases where the new size of the calendar component is dependent on the manually computed value of parent container.
In these cases, fullcalendar is inefficient because in effect the resize event is being triggered way too often.
This pull request simply delegates the responsibility to resize to the user of the fullcalendar control.