Fix: minitest--post-command regexp so verify single will work #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests that contain # or : are not working correctly when running verify-single, because the regexp strips out the # and : characters and the test names no longer match up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests that contain # or : are not working correctly when running verify-single, because the regexp strips out the # and : characters and the test names no longer match up.
Its possible that this was necessary with earlier versions of Ruby/Minitest. I'm currently testing this against Minitest 5.11.3 with Ruby 2.6.3. I have not yet tested this with older versions of minitest, but I could not find anything in the changelog that specifically referenced this behavior.
Perhaps this is operating system specific? I can verify the change works for me for tests that contain a # or :: now. I'm not sure if this addresses issue #39 because the behavior there is different.