Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AsciidoctorDiagram doesn't work with Asciidoctor 1.5.6 #154

Closed
robertpanzer opened this issue Jul 13, 2017 · 1 comment
Closed

AsciidoctorDiagram doesn't work with Asciidoctor 1.5.6 #154

robertpanzer opened this issue Jul 13, 2017 · 1 comment

Comments

@robertpanzer
Copy link
Member

Rendering a document containing a diagram with Asciidoctor 1.5.6 and Asciidoctor-Diagram 1.5.4 fails with a Nil error unless substitutions are explicitly defined for that block.
This is because https://github.com/asciidoctor/asciidoctor-diagram/blob/master/lib/asciidoctor-diagram/extensions.rb#L410-L417 returns nil instead of an empty list.

To reproduce try to render this document with Asciidoctor 1.5.6 and Asciidoctor-Diagram 1.5.4:

= Document Title

[ditaa,asciidoctor-diagram-process]
....
                   +-------------+
                   | Asciidoctor |-------+
                   |   diagram   |       |
                   +-------------+       | PNG out
                       ^                 |
                       | ditaa in        |
                       |                 v
 +--------+   +--------+----+    /---------------\
 |        |---+ Asciidoctor +--->|               |
 |  Text  |   +-------------+    |   Beautiful   |
 |Document|   |   !magic!   |    |    Output     |
 |     {d}|   |             |    |               |
 +---+----+   +-------------+    \---------------/
     :                                   ^
     |          Lots of work             |
     +-----------------------------------+
....
robertpanzer added a commit to robertpanzer/asciidoctor-diagram that referenced this issue Jul 13, 2017
robertpanzer added a commit to robertpanzer/asciidoctor-diagram that referenced this issue Jul 13, 2017
@mojavelinux
Copy link
Member

mojavelinux commented Jul 13, 2017

We've identified the problem. It is safe to say that Asciidoctor 1.5.6 requires Asciidoctor Diagram 1.5.5 (the next release).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants