Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run asciidoctor-epub3 in-process #534

Closed
slonopotamus opened this issue Mar 5, 2020 · 2 comments
Closed

Run asciidoctor-epub3 in-process #534

slonopotamus opened this issue Mar 5, 2020 · 2 comments

Comments

@slonopotamus
Copy link
Contributor

slonopotamus commented Mar 5, 2020

The only reason why a forked JVM is spawned to run asciidoctor-epub3 I know is passing path to Kindlegen executable. But, since asciidoctor/asciidoctor-epub3#277 (already available in current asciudoctor-epub3 release that you use), it is possible to pass path through ebook-kindlegen-path document attribute, so it looks like there's no more need to fork.

If you encounter any issues implementing this, feel free to bugreport them to asciidoctor-epub3 project.

@ysb33r
Copy link
Member

ysb33r commented Mar 5, 2020

Feel free to make the relevant change and push it. If the test all pass then we are good.

@ysb33r
Copy link
Member

ysb33r commented Apr 12, 2020

This will run in process from Gradle 6.0+. In previous versions it will still be run out of process as Gradle leaks snakeyaml onto the classpath.

@ysb33r ysb33r closed this as completed Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@slonopotamus @ysb33r and others