Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table not generated correctly when one column contain bullet list #23

Closed
ysb33r opened this issue Apr 7, 2015 · 3 comments
Closed

Table not generated correctly when one column contain bullet list #23

ysb33r opened this issue Apr 7, 2015 · 3 comments

Comments

@ysb33r
Copy link
Member

ysb33r commented Apr 7, 2015

The following will not generate the source block.

[cols="2*"]
|===
a|
[source,groovy]
----
myTask {
    mySources file( 'path/foobar' )
    mySources new File( 'path2/foobar' )
    mySources 'file3', 'file4'
    mySources { "lazy evaluate file name later on" }
}
----
a|
* Allow ability to:
* Use strings and other objects convertible to `File`
* Append lists
* Evaluate as late as possible
* Reset default values
|===

If both columns contain a source block then both are generated.

@mojavelinux
Copy link
Member

Are you sure the source listing isn't just flowing off the screen due to the text size of the itemized list? We could implement the vertical alignment in the reveal.js backend so that the code listing is pushed to the top. We'd need to add the following to a built-in stylesheet:

td.valign-top {
  vertical-align: top;
}

@wackywendell
Copy link
Contributor

It looks to me like @mojavelinux is right on with the vertical-alignment issue. I removed a couple items from the list:

== Table

[cols="2*"]
|===
a|
[source,groovy]
----
myTask {
    mySources file( 'path/foobar' )
    mySources new File( 'path2/foobar' )
    mySources 'file3', 'file4'
    mySources { "lazy evaluate file name later on" }
}
----
a|
* A list item
* Another list item
* A third list item
|===

Which gives this result:

screen shot 2015-05-06 at 10 55 54 am

With more list items (as given in the initial issue), I get this:

screen shot 2015-05-06 at 10 59 46 am

@obilodeau
Copy link
Member

With current master, it's not pretty but it works:

Selection_007

Since this is a really old ticket I'm just going to close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants