Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade bundled font-awesome from 4.3.0 → 5.8.2 #268

Merged
merged 1 commit into from
Dec 24, 2019

Conversation

bentolor
Copy link
Contributor

I was missing quite a bunch of new icons which appeared
in https://fontawesome.com/icons?d=gallery&m=free but
did not work.

This udpates font awesome to the latest CDN-available
version

I was missing quite a bunch of new icons which appeared
in https://fontawesome.com/icons?d=gallery&m=free but
did not work.

This udpates font awesome to the latest CDN-available
version
@ggrossetie
Copy link
Member

As mention by Dan, I believe that FontAwesome 5 is not 100% backward compatible with FontAwesome 4 (ie. some icons names changed).
So we should probably add a note on the CHANGELOG.

@mojavelinux
Copy link
Member

That's correct. For the record, Asciidoctor PDF is already on FontAwesome 5, so I'm okay with other packages in the ecosystem using it. We just have to be very careful with core since that's where the highest expectation is for things not to break. And if other packages move, it will make the transition in core easier.

@obilodeau
Copy link
Member

I'm surprised this didn't break a bunch of tests. I see this is testing for the iconfont-remote attribute. I don't think we have test coverage on that. I'm going to need to dig a little bit deeper into that.

@obilodeau obilodeau merged commit 649fc34 into asciidoctor:master Dec 24, 2019
obilodeau added a commit that referenced this pull request Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants