Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug? title-slide-background-video but only background-opacity #323

Closed
bentolor opened this issue Jan 30, 2020 · 5 comments · Fixed by #325
Closed

Bug? title-slide-background-video but only background-opacity #323

bentolor opened this issue Jan 30, 2020 · 5 comments · Fixed by #325

Comments

@bentolor
Copy link
Contributor

See :

data-background-opacity=(attr "background-opacity")

All title slides attributes are in the form title-slide-xxx except opacity, which is only background-opacity. Is this by design or a bug?

@obilodeau
Copy link
Member

obilodeau commented Jan 30, 2020

Great catch! Introduced in aeb4fd0, PR #269. Mislabeled feature present in 3.0.0 and 3.1.0. So it has only been out there for a short while. Will fix in 4.0.0 with an upgrade note.

@bentolor
Copy link
Contributor Author

Yeah – I'm this strange guy actually using these weird features nobody ever think they're needed.

I'm must say I'm really quite impressed with the coverage of the rather esoteric revealjs features!

@bentolor
Copy link
Contributor Author

Oh – it was me introducing this bug? What a shame! Sorry, @obilodeau

@obilodeau
Copy link
Member

My latest deck for an internal presentation started using background-opacity. Haven't applied it to a title slide though. Using opacity is pretty neat, especially for video backgrounds. I was surprised by the quality of the royalty-free videos on Pixabay. I'll definitely do more of this.

I noticed that opacity hasn't been integrated into the background image new syntax though:

== !

image::landscape.jpg[background, size=contain, opacity=0.7]

I'll try to add that eventually.

@bentolor
Copy link
Contributor Author

I found https://www.pexels.com/ also to be an astonishing source of high-quality, no-fuss free video content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants