Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapsible blocks #484

Open
ebousse opened this issue Nov 15, 2022 · 2 comments
Open

Collapsible blocks #484

ebousse opened this issue Nov 15, 2022 · 2 comments

Comments

@ebousse
Copy link

ebousse commented Nov 15, 2022

Asciidoc provides a way to declare collapsible blocks, as written in the documentation:
https://docs.asciidoctor.org/asciidoc/latest/blocks/collapsible/

And when using the regular HTML5 generator of asciidoctor, a collapsible block is generated in this way:
<details> <summary class="title">Details</summary> … </details>

However, when using asciidoctor-reveal.js, this code is generated:
<div class="exampleblock">…

Is it planned to support collapsible blocks in asciidoctor-reveal.js? And in fact, since it relies on the HTML5 generator of asciidoctor, why isn't it already enabled?

Thanks for reading me!

@ggrossetie
Copy link
Member

Hello Erwan,

The reason is that we are overriding the built-in converter with templates: https://github.com/asciidoctor/asciidoctor-reveal.js/blob/master/templates/example.html.slim

So we need to implement this logic in the example.html.slim template. Feel free to submit a pull request to add this feature, I will gladly merge it!

@ebousse
Copy link
Author

ebousse commented Nov 15, 2022

Thank you for answering! Makes sense now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants