Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace internal use of numbered attribute by sectnums #1120

Closed
abelsromero opened this issue Oct 8, 2022 · 0 comments · Fixed by #1124
Closed

Replace internal use of numbered attribute by sectnums #1120

abelsromero opened this issue Oct 8, 2022 · 0 comments · Fixed by #1124
Labels
enhancement

Comments

@abelsromero
Copy link
Member

numbered is considered legacy and while still supported we should probably just change it.

ref:

asciidoctorj/asciidoctorj-api/src/main/java/org/asciidoctor/Attributes.java

Line 41 in 2a57067

public static final String SECTION_NUMBERS = "numbered";

@abelsromero abelsromero mentioned this issue Oct 12, 2022
Merged
6 tasks
abelsromero added a commit to abelsromero/asciidoctorj that referenced this issue Oct 12, 2022
@abelsromero
Replace use of deprecated 'numbered' attribute by 'sectnums'
a1815ad 
Fixes asciidoctor#1120
abelsromero added a commit to abelsromero/asciidoctorj that referenced this issue Oct 12, 2022
@abelsromero
Replace use of deprecated 'numbered' attribute by 'sectnums'
4470095 
Fixes asciidoctor#1120
robertpanzer pushed a commit to robertpanzer/asciidoctorj that referenced this issue Oct 16, 2022
@abelsromero @robertpanzer
Replace use of deprecated 'numbered' attribute by 'sectnums'
911a6ab 
Fixes asciidoctor#1120
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace use of deprecated 'numbered' attribute by 'sectnums' abelsromero/asciidoctorj
1 participant
@abelsromero