Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trouble with asciidoctorj-pdf version 1.5.0-alpha.10 #403

Closed
charleech opened this issue Nov 4, 2015 · 4 comments
Closed

Trouble with asciidoctorj-pdf version 1.5.0-alpha.10 #403

charleech opened this issue Nov 4, 2015 · 4 comments
Assignees
Labels
Milestone

Comments

@charleech
Copy link

Hi,

I've been noticed that the latest version of asciidoctorj-pdf:1.5.0-alpha.10 is available at the Maven Central. Thank you for your effort. It is a good works.

My project use asciidoctor-maven-plugin:1.5.2.1. I'm trying to update its dependency to asciidoctorj-pdf:1.5.0-alpha.10 and found some trouble about the asciidoctorj-pdf:1.5.0-alpha.10 as the following: -

  1. There is no bundled rouge .
  2. The prawn-icon:1.0.0 does not has the fontawesome.

Could you please help to advise further? Thank you very much for your help in advance. I'm looking forward to hearing from you soon.

Regards,

Charlee Ch.

@robertpanzer robertpanzer added this to the v1.5.3.2 milestone Nov 4, 2015
@robertpanzer robertpanzer self-assigned this Nov 4, 2015
@mojavelinux
Copy link
Member

It appears that we lost all the fonts from prawn-icon. I think we need a double star matcher here because the fonts are in subfolders.

include "gems/*/data/fonts/*"

Rouge is an optional dependency, so AsciidoctorJ PDF needs to declare it explicitly in build.gradle.

Robert, how would you like to proceed? Perhaps we can name the AsciidoctorJ PDF version 1.5.0.alpha.10.1?

@robertpanzer
Copy link
Member

Darn it!
I was pretty sure that I copied the dependencies and gemFiles from the branched file.
Apparently I did not.

@robertpanzer
Copy link
Member

Robert, how would you like to proceed? Perhaps we can name the AsciidoctorJ PDF version 1.5.0.alpha.10.1?

Yes, sounds good.
I just will have to give on taking the gem version from the project version and set it directly:

asciidoctorPdfGemVersion = project(':asciidoctorj-pdf').version.replace('-', '.')

@mojavelinux
Copy link
Member

Probably just comment that out and make a note about it that it's temporary, then revert it after you publish. That way, you don't forgot to change it back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants