Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asciidoctorj cli should not hardcode the doctype #424

Closed
mojavelinux opened this issue Jan 10, 2016 · 0 comments
Closed

asciidoctorj cli should not hardcode the doctype #424

mojavelinux opened this issue Jan 10, 2016 · 0 comments
Assignees
Labels
Milestone

Comments

@mojavelinux
Copy link
Member

The asciidoctorj cli should not hardcode the doctype to article by default. The default should be unset.

By setting the doctype attribute from the cli automatically, this prevents the document from being able to define the doctype. As a result, it's not possible to use asciidoctorj on a mixed set of documents (documents with different doctypes).

To demonstrate this problem, run the AsciidoctorInvoker with no flags defined on a document that defines its doctype as book:

= Title
:doctype: book

= Part 1

== Chapter 1

It was a dark and stormy night.

This will result in the following warning:

asciidoctor: ERROR: book.adoc: line 4: only book doctypes can contain level 0 sections
@mojavelinux mojavelinux added this to the v1.5.5 milestone Jan 10, 2016
@mojavelinux mojavelinux self-assigned this Jan 10, 2016
robertpanzer added a commit that referenced this issue Jan 11, 2016
resolves #424 don't set doctype by default in asciidoctorj cli
abelsromero pushed a commit to abelsromero/asciidoctorj that referenced this issue Dec 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant