Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(v3.0.x) Update Antora metadata for v3.0.0-alpha.1 prerelease #1224

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

abelsromero
Copy link
Member

Thank you for opening a pull request and contributing to AsciidoctorJ!

Please take a bit of time giving some details about your pull request:

Kind of change

  • Bug fix
  • New non-breaking feature
  • New breaking feature
  • Documentation update
  • Build improvement

Description

What is the goal of this pull request?
Prepare metadata to publish the docs as pre-release.
I tested building the docs from the playbook from https://github.com/asciidoctor/docs.asciidoctor.org and it worked well.
Both versions appear...btw, I will remove v2.4 from the published docs, last release was Feb 21, no point in keeping the docs since that version is no longer maintained.
image
When clicking on the "AsciidoctorJ" title, 2.5 is loaded by default 👌

How does it achieve that?
Update the metadata, after that, I'll create the PR to http://github.com/asciidoctor/docs.asciidoctor.org to remove v2.4 and publish v3.0.x as a pre-release according to https://asciidoctor.zulipchat.com/#narrow/stream/279644-users.2Fasciidoctorj/topic/Publish.203.2E0.2E0-alpha.2E1.20docs.

Are there any alternative ways to implement this?
Tested using prerelease: true and did not appreciate any difference. So I am going with the original proposal.

Are there any implications of this pull request? Anything a user must know?
No

Issue

If this PR fixes an open issue, please add a line of the form:

No issue.

Release notes

Please add a corresponding entry to the file CHANGELOG.adoc

Docs are published from docs.asciidoctor.org repo, it doesn't make sense to me to add anything to the changelog.

@robertpanzer
Copy link
Member

Thanks!

@robertpanzer robertpanzer merged commit 6088e5b into asciidoctor:main Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants