Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make methods on JavaExtensionRegistry return itself instead of void t… #491

Merged
merged 1 commit into from
Jul 21, 2016

Conversation

robertpanzer
Copy link
Member

…o allow chaining of method calls

@abelsromero
Copy link
Member

Silly thing, but it always have puzzled me why docinfoProcessor uses Camel when the rest of processors don’t: preprocessor, postprocessor, treeprocessor.
Then we have blockMacro, inlineMacro.

@mojavelinux
Copy link
Member

These are silly English rules. Preprocessor is a single word, so it goes to all lowercase. You could argue the case for Postprocessor being a single word or two words...but some dictionaries have it as a single word. Treeprocessor is not a real word, so I followed the pattern. For certain, there is no word "docinfoprocessor", so we have to use camel case. The same for the others.

@abelsromero
Copy link
Member

I had the impression it was something like that, I know you give a lot of thought to those details.
It was obvious for macro method, but not so (for me) for the other ones.

@robertpanzer robertpanzer merged commit fc02f33 into asciidoctor:asciidoctorj-1.6.0 Jul 21, 2016
@robertpanzer robertpanzer deleted the issue_488 branch July 21, 2016 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants