Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve user experience when using always_keep_download = yes #922

Closed
delgurth opened this issue Apr 13, 2021 · 0 comments · Fixed by #1644
Closed

Improve user experience when using always_keep_download = yes #922

delgurth opened this issue Apr 13, 2021 · 0 comments · Fixed by #1644

Comments

@delgurth
Copy link

As discussed here: https://github.com/asdf-vm/asdf/discussions/905

should we introduce a warning to the user about always_keep_download = yes not working if the plugin does not contain a bin/download script?

Please add a warning in the install phase when we detect the user has configured always_keep_download = yes and the plugin the user is using does not have the required bin/download script to be able to support this.

This to prevent bug reports in plugins like: halcyon/asdf-java#125

This warning might also be an incentive to plugin developers to add the bin/download script. So I guess this warning should also include a link to documentation to explain what is needed from the plugin developer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant