fix(actions): generic action had exit and init reversed

Didn't seem to cause any problems. But would have definitely caused issues with extending the ActionGeneric class. #35
ashblue · Mar 24, 2021 · ff7dbc2 · ff7dbc2
1 parent 0e330d7
commit ff7dbc2
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 4 deletions.
diff --git a/Assets/FluidBehaviorTree/Runtime/Tasks/Actions/ActionGeneric.cs b/Assets/FluidBehaviorTree/Runtime/Tasks/Actions/ActionGeneric.cs
@@ -20,11 +20,11 @@ protected override void OnStart () {
         }
 
         protected override void OnExit () {
-            initLogic?.Invoke();
+            exitLogic?.Invoke();
         }
 
         protected override void OnInit () {
-            exitLogic?.Invoke();
+            initLogic?.Invoke();
         }
     }
-}
+}
diff --git a/Assets/FluidBehaviorTree/Tests/Editor/Tasks/Actions/ActionGenericTest.cs b/Assets/FluidBehaviorTree/Tests/Editor/Tasks/Actions/ActionGenericTest.cs
@@ -44,6 +44,19 @@ public void It_should_execute_a_init_hook () {
                 Assert.AreEqual(1, test);
             }
 
+            [Test]
+            public void It_should_execute_init_hook_on_continue () {
+                var test = 0;
+                var task = new ActionGeneric {
+                    initLogic = () => { test++; },
+                    updateLogic = () => TaskStatus.Continue,
+                };
+
+                task.Update();
+
+                Assert.AreEqual(1, test);
+            }
+
             [Test]
             public void It_should_execute_a_exit_hook () {
                 var test = 0;
@@ -57,4 +70,4 @@ public void It_should_execute_a_exit_hook () {
             }
         }
     }
-}
+}