Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CRITICAL] The custom fields should be fixtures. #3

Open
Don-Leopardo opened this issue Jun 24, 2019 · 2 comments
Open

[CRITICAL] The custom fields should be fixtures. #3

Don-Leopardo opened this issue Jun 24, 2019 · 2 comments

Comments

@Don-Leopardo
Copy link

The custom fields should be exported by bench --site site_name export-fixtures because if they continue as they are now (with the custom folder and the .json file for each doctype), they overwrite every other custom field when you perform a bench migrate. This is a critical bug and should be solved.

@ashish-greycube
Copy link
Owner

@Don-Leopardo ,
If I look at following 3 json, what i find is only fields i am changing

[a]https://github.com/ashish-greycube/jodit_html_editor/blob/master/jodit_html_editor/jodit/custom/item.json
(1)New field added - jodit_editor
(2)web_long_description - existing field made hidden

[b]https://github.com/ashish-greycube/jodit_html_editor/blob/master/jodit_html_editor/jodit/custom/web_form.json
(1)New field added - jodit_editor
(2) introduction_text - existing field made hidden

[c]https://github.com/ashish-greycube/jodit_html_editor/blob/master/jodit_html_editor/jodit/custom/web_page.json
(1)New field added - jodit_editor
(2) main_section - existing field made hidden

So i am not sure bench migrate would overwrite other custom fields as my json has only above mentioned changes.
Please guide if I am not understanding. Thanks!

@Don-Leopardo
Copy link
Author

The problem is the way it's done. We had that problem in production, it overwrites all fields from the Item table. We had to uninstall the app. Try using export-fixtures, it should solve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants