Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS 2019 support #8

Open
NielsUll opened this issue Dec 3, 2019 · 6 comments
Open

VS 2019 support #8

NielsUll opened this issue Dec 3, 2019 · 6 comments

Comments

@NielsUll
Copy link

NielsUll commented Dec 3, 2019

Do you plan to support VS 2019?

@ashmind
Copy link
Owner

ashmind commented Dec 4, 2019

Thanks for asking. Not sure -- eventually yes, but no specific timeline for it.

At my current workplace we mostly work at one solution as compared to 5 at the previous place, so for now I don't actively need this. Would be happy to accept a pull request though.

@ygoe
Copy link

ygoe commented Nov 2, 2020

I've started working on this but got stuck with the AsyncPackage thing, again. VS SDK really sucks. I've asked for help in the repo where they explain the "simplest way" to handle this, because none of that actually works.

(For now, I've just updated the version numbers and accepted loading of synchronous packages in VS 2019. That works well and is already really helpful when working with multiple solutions at the same time. But it probably can't be uploaded to the VS marketplace in this state. I also recommend 7+ Taskbar Tweaker to always ungroup VS windows so you can actually see this in the taskbar.)

@learn-more
Copy link

I have created a module for Windhawk that provides this support for 2017 and 2019:
https://windhawk.net/mods/lm-vs-solution-icon

The icon generation code is based on this extension.

@ygoe
Copy link

ygoe commented Apr 25, 2022

@learn-more Interesting. Does it also load the solution-provided icon from the file? And can it handle VS 2022? (Now that VS 2019 shows a warning that it's no longer supported and we should finally upgrade to 2022.)

@learn-more
Copy link

@learn-more Interesting. Does it also load the solution-provided icon from the file? And can it handle VS 2022? (Now that VS 2019 shows a warning that it's no longer supported and we should finally upgrade to 2022.)

No, for now it only loads creates an icon from the filename.
I was planning on adding support for the .editoricon.ico file, but nothing beyond that yet.

Currently I don't have access to a machine with 2022, so I was unable to test that.

@ygoe
Copy link

ygoe commented Nov 17, 2022

On this issue's topic: Maybe it's worth extending this new extension to also show icons instead of just funny colours that nobody will remember?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants