Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ImportError when an INSTALLED_APP is a dotted path to an AppConfig #19

Merged
merged 2 commits into from
Aug 2, 2016

Conversation

wadevries
Copy link
Contributor

I have an INSTALLED_APPS setting which contains a dotted path to an AppConfig, like so:

INSTALLED_APPS = [
    # some normal apps...,
    'myproject.myapp.MyAppConfig',
    # some more apps...,
]

Somehow the import_module inside the import_crud will raise an ImportError, even though Django manages to import it as an app. If we catch the ImportError here, crudbuilder will function as normal.

Django docs on INSTALLED_APPS

@coveralls
Copy link

coveralls commented Aug 2, 2016

Coverage Status

Coverage remained the same at 78.748% when pulling ebc64a0 on wadevries:dotted-app-import into b38c323 on asifpy:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 78.748% when pulling ebc64a0 on wadevries:dotted-app-import into b38c323 on asifpy:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 78.748% when pulling ebc64a0 on wadevries:dotted-app-import into b38c323 on asifpy:master.

@coveralls
Copy link

coveralls commented Aug 2, 2016

Coverage Status

Coverage remained the same at 78.748% when pulling 07aecfb on wadevries:dotted-app-import into b38c323 on asifpy:master.

@asifpy asifpy merged commit b1ff1fa into asifpy:master Aug 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants