Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting to turn off Async suggestion for private methods #44

Open
Allesad opened this issue Oct 19, 2016 · 1 comment
Open

Setting to turn off Async suggestion for private methods #44

Allesad opened this issue Oct 19, 2016 · 1 comment
Milestone

Comments

@Allesad
Copy link

Allesad commented Oct 19, 2016

For clients of particular type only public method names matters. There is no need to suggest Async suffix for private methods. For example I have public methods which checks for arguments or states and throws exceptions immediately (these methods don't have 'async' keyword for 'fail-fast' reasons). And these methods delegate actual work to some private methods like "DoSomeActionInternal" or something like that. These method are hidden from outer client so it's pretty annoying to have suffix suggestions.
It would be nice to have some settings to turn off these suggestions for private methods.

@asizikov
Copy link
Owner

@Allesad thanks for the suggestion.

Could you please provide me with a test case? Like a sample class with some methods in it, and mark with comments where do you see a false positive warning.

@asizikov asizikov added this to the 2017.1 milestone Apr 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants