Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use egui-glow instead of custom implementation of egui #216

Closed
asny opened this issue Mar 23, 2022 · 3 comments
Closed

Use egui-glow instead of custom implementation of egui #216

asny opened this issue Mar 23, 2022 · 3 comments
Labels

Comments

@asny
Copy link
Owner

asny commented Mar 23, 2022

  • Deprecate egui implementation
  • Use egui-glow in examples
@asny asny added the 0.11 label Mar 23, 2022
@asny asny removed the 0.11 label Apr 1, 2022
@asny
Copy link
Owner Author

asny commented Apr 1, 2022

It's easy to use egui-glow with a winit window, but not on web. So there are several options as I see it:

  • Use egui-glow Painter and implement event mapping etc. in every example that requires gui
  • Use eframe instead of a three-d window for those examples that requires gui
  • Keep an implementation of egui (use egui-glow for native and a custom for web)
  • Make a contribution to egui to make egui-glow support web
  • Only have a gui on native

@emilk
Copy link
Contributor

emilk commented Apr 7, 2022

egui_glow::Painter is already being used for web by egui_web, so it should not be too much work to use egui_glow::Painter in three-d.

@asny
Copy link
Owner Author

asny commented Aug 10, 2022

I decided to keep an egui implementation to avoid duplicating the necessary code everywhere. However, that implementation is using egui-glow so it is a really thin wrapper, most of the code is for mapping from three-d input (for example events) to egui input.

@asny asny closed this as completed Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants