red-knot: support narrowing for bool(E) #14668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorskees
requested review from
carljm,
MichaReiser,
AlexWaygood and
sharkdp
as code owners
|
AlexWaygood
approved these changes
Nov 29, 2024
sharkdp
reviewed
Nov 29, 2024
crates/red_knot_python_semantic/resources/mdtest/narrow/conditionals/boolean.md
Outdated
Show resolved
Hide resolved
sharkdp
reviewed
Dec 2, 2024
crates/red_knot_python_semantic/resources/mdtest/narrow/conditionals/boolean.md
Outdated
Show resolved
Hide resolved
sharkdp
reviewed
Dec 2, 2024
crates/red_knot_python_semantic/resources/mdtest/narrow/conditionals/boolean.md
Outdated
Show resolved
Hide resolved
sharkdp
reviewed
Dec 2, 2024
|
Just a note for future: this issue was assigned to me, and not marked "help wanted", because I created it specifically as a ramp-up task for someone joining the Astral team this week :) It's totally fine that you took it on (thanks for the contribution!), but in future it's best to check if an issue is assigned to someone before starting work on it, and if so, comment on the issue to check if you can take it over without duplicating someone's work-in-progress. |
carljm
reviewed
Dec 2, 2024
crates/red_knot_python_semantic/resources/mdtest/narrow/bool-call.md
Outdated
Show resolved
Hide resolved
carljm
reviewed
Dec 3, 2024
carljm
approved these changes
Dec 3, 2024
dcreager
added a commit
that referenced
this pull request
Dec 3, 2024
* main: [`ruff`] Extend unnecessary-regular-expression to non-literal strings (`RUF055`) (#14679) Minor followups to RUF052 (#14755) [red-knot] Property tests (#14178) [red-knot] `is_subtype_of` fix for `KnownInstance` types (#14750) Improve docs for flake8-use-pathlib rules (#14741) [`ruff`] Implemented `used-dummy-variable` (`RUF052`) (#14611) [red-knot] Simplify tuples containing `Never` (#14744) Possible fix for flaky file watching test (#14543) [`flake8-import-conventions`] Improve syntax check for aliases supplied in configuration for `unconventional-import-alias (ICN001)` (#14745) [red-knot] Deeper understanding of `LiteralString` (#14649) red-knot: support narrowing for bool(E) (#14668) [`refurb`] Handle non-finite decimals in `verbose-decimal-constructor (FURB157)` (#14596) [red-knot] Re-enable linter corpus tests (#14736)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #14547 by delegating narrowing to
Eforbool(E)whereEis some expression.This change does not include other builtin class constructors which should also work in this position, like
int(..)orfloat(..), as the original issue does not mention these. It should be easy enough to add checks for these as well if we want to.I don't see a lot of markdown tests for malformed input, maybe there's a better place for the no args and too many args cases to go?
I did see after the fact that it looks like this task was intended for a new hire.. my apologies. I got here from #13694, which is marked help-wanted.