Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recategorize runtime-string-union to TCH010 #9721

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Recategorize runtime-string-union to TCH010 #9721

merged 1 commit into from
Jan 31, 2024

Conversation

charliermarsh
Copy link
Member

Summary

This rule was added to flake8-type-checking as TC010. We're about to stabilize it, so we might as well use the correct code.

See: #9573.

@charliermarsh charliermarsh requested a review from zanieb January 30, 2024 21:05
@charliermarsh charliermarsh marked this pull request as ready for review January 30, 2024 21:05
@charliermarsh charliermarsh merged commit 798e72c into release/0.2.0 Jan 31, 2024
17 checks passed
@charliermarsh charliermarsh deleted the charlie/t branch January 31, 2024 04:28
@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check encountered linter errors. (no lint changes; 1 project error)

sphinx-doc/sphinx (error) 

warning: The `show-source` option has been deprecated in favor of `output-format`'s "full" and "concise" variants. Please update your configuration to use `output-format = <full|concise>` instead.
ruff failed
  Cause: Selection of unstable rules without the `--preview` flag is not allowed. Enable preview or remove selection of:
	- FURB131
	- FURB113
	- FURB132

Linter (preview)

ℹ️ ecosystem check encountered linter errors. (no lint changes; 2 project errors)

fronzbot/blinkpy (error) 

ruff check --no-cache --exit-zero --output-format concise --preview

warning: The top-level linter settings are deprecated in favour of their counterparts in the `lint` section. Please update the following options in your configuration:
  - 'ignore' -> 'lint.ignore'
  - 'select' -> 'lint.select'
  - 'mccabe' -> 'lint.mccabe'
  - 'per-file-ignores' -> 'lint.per-file-ignores'


ruff failed
  Cause: Selection of deprecated rule `TRY200` is not allowed when preview mode is enabled.

sphinx-doc/sphinx (error) 

ruff check --no-cache --exit-zero --output-format concise --preview

warning: The `show-source` option has been deprecated in favor of `output-format`'s "full" and "concise" variants. Please update your configuration to use `output-format = <full|concise>` instead.
ruff failed
  Cause: Selection of deprecated rule `ANN102` is not allowed when preview mode is enabled.

@zanieb zanieb mentioned this pull request Feb 1, 2024
Merged
zanieb pushed a commit that referenced this pull request Feb 1, 2024
@charliermarsh @zanieb
Recategorize runtime-string-union to TCH010 (#9721)
28672fe 
## Summary

This rule was added to `flake8-type-checking` as `TC010`. We're about to
stabilize it, so we might as well use the correct code.

See: #9573.
zanieb pushed a commit that referenced this pull request Feb 1, 2024
@charliermarsh @zanieb
Recategorize runtime-string-union to TCH010 (#9721)
85a7edc 
## Summary

This rule was added to `flake8-type-checking` as `TC010`. We're about to
stabilize it, so we might as well use the correct code.

See: #9573.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanieb zanieb Awaiting requested review from zanieb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@charliermarsh