Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
So the error here is:
This isn't a Reqwest error, so we miss it in
is_extended_transient_error
.We could add
TarError
orExtractError
here, but... should we? This PR just extends it to any error that has an IO source. I don't see much of a downside.Closes #9747.
Test Plan
First, ran:
uv run ./scripts/create-python-mirror.py --name cpython --arch aarch64 --os darwin
.Then, dropped this into
./scripts/mirror/server.py
:Then ran
python server.py
from that directory.From there, ran
UV_PYTHON_INSTALL_MIRROR="http://localhost:8080" cargo run python install 3.11 --reinstall --verbose
to reliably test retries.