Rename Python install scratch directory from .cache -> .temp
#9756
+17
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
added
the
enhancement
|
What about |
zanieb
force-pushed
the
zb/python-install-scratch
branch
from
6bacb8e to
d19d22e
Compare
zanieb
changed the title
.cache -> .scratch.cache -> .temp
| self.root.join(".cache") | ||
| /// Return the location of the scratch directory for managed Python installations. | ||
| pub fn scratch(&self) -> PathBuf { | ||
| self.root.join(".temp") |
There was a problem hiding this comment.
I think the rename here is now showing a warning:
WARN Ignoring malformed managed Python entry:
Failed to parse Python installation key `.cache`: not enough `-`-separated values
Can you look for the usages? I think we exclude files that match this name somewhere, and now .cache exists for users but won't be skipped.
zanieb
added a commit
that referenced
this pull request
Dec 10, 2024
…scovery (#9786) Addresses #9756 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing the confusion in #9749