Don't read metadata from stale .egg-info files
#9760
Merged
+171
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to add a test here. |
charliermarsh
force-pushed
the
charlie/egg
branch
from
a793a58 to
ed5e61d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We were reading an
.egg-infofile from the root directory that didn't apply to the root member -- it was for another workspace member. I think this is driven from some idiosyncracies in thesetuptoolssetup for that workspace member, but it's still wrong to fail.This PR adds a few measures to fix this:
egg-infofilename against the package metadata.egg-infofile or similar. This is an optimization anyway; worst case, we try to build the package, then fail there.Closes #9743.