Skip to content
This repository has been archived by the owner on Nov 11, 2024. It is now read-only.

astropy-helpers should respect python_requires #462

Closed
bsipocz opened this issue Apr 23, 2019 · 2 comments · Fixed by #474
Closed

astropy-helpers should respect python_requires #462

bsipocz opened this issue Apr 23, 2019 · 2 comments · Fixed by #474
Labels

Comments

@bsipocz
Copy link
Member

bsipocz commented Apr 23, 2019

Matplotlib stopped supporting python3.5 in their new release (it's not a release just yet, but 3.1rc1). This causes failure on our CI here for the python3.5 build.

However this our own fault as the machinery here doesn't respect the python_requires in mpl's setup.py.

@tacaswell kindly digged up that the offending lines are likely

from setuptools import Distribution
dist = Distribution()
eggs = dist.fetch_build_eggs('sphinx-astropy')

from setuptools import Distribution
dist = Distribution()
eggs = dist.fetch_build_eggs('sphinx-astropy')

I'll work this around for our CI to get the RC out sooner rather than later, but it would be great if we fix this before the actual release (and it may need to be backported, to LTS, too).

@astrofrog
Copy link
Member

I think this is because setuptools doesn’t recognise python_requires. Not sure if we can easily use pip instead though.

@bsipocz
Copy link
Member Author

bsipocz commented Apr 23, 2019

Or give up on seamlessly install sphinx-astropy and ask packages to explicitly list it (as they need to do it with pytest, sphinx, etc.)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants