Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add TAP based NRAO module #2316

Open
jjtobin opened this issue Mar 1, 2022 · 8 comments
Open

ENH: Add TAP based NRAO module #2316

jjtobin opened this issue Mar 1, 2022 · 8 comments

Comments

@jjtobin
Copy link

jjtobin commented Mar 1, 2022

The NRAO legacy archive, which is queried via astroquery.nrao, will be unavailable to users outside the NRAO domains beginning on or about May 2, 2022; the NRAO legacy archive will be fully retired at some point after May 2nd.. The new NRAO archive service is accessible from data.nrao.edu and is not compatible with the existing interface. We suggest that astroquery.nrao in its current state be marked for deprecation.

A scriptable interface for the new NRAO archive has not yet been implemented and we'll work with you all to implement an astroquery interface once it is available.

@jjtobin jjtobin changed the title NRAO legacy archive will be unavailable to external users ~May 2nd, 2022 NRAO legacy archive will be unavailable to external users ~May 2, 2022 and astroquery.nrao should be deprecated. Mar 1, 2022
@keflavich
Copy link
Contributor

@jjtobin Thanks for the heads up!

We welcome contributions from the NRAO to provide a new scripted interface to the new archive. I'll be happy to talk to you & the development team on what that should look like. It would be best if a pull request is opened here and marked "WIP" (work-in-progress) so that the astroquery community is able to offer feedback early in the development process.

@keflavich keflavich added the nrao label Mar 1, 2022
@bsipocz
Copy link
Member

bsipocz commented Apr 27, 2022

Any update on the upgrade of the module? 2nd of May is fast approaching.

@jjtobin
Copy link
Author

jjtobin commented Apr 27, 2022

It sounds like the scripted interface implementation (via TAP) would start in the next couple months. There will be a gap in capability where the legacy archive is unavailable and the new service is brought online. I will try to keep you all updated and see if I can pull @keflavich into any relevant meetings regarding development.

@bsipocz
Copy link
Member

bsipocz commented Apr 27, 2022

In the meantime it maybe worth adding a warning and disabling the module altogether? We don't plan to do a release any in the upcoming weeks, yet the dev version of astroquery would not simply fail the tests, etc.

@privong
Copy link
Contributor

privong commented Sep 27, 2022

@jjtobin Can perhaps say more, but the TAP interface to the new NRAO archive is online. Info here: https://science.nrao.edu/srdp/scripted-access-to-the-nrao-archive

@bsipocz
Copy link
Member

bsipocz commented Sep 27, 2022

@privong @jjtobin - the question is really, is there any plans and resources to refactor the module to use the tap interface? I would like to include such an enhancement, but until it comes to live we're considering removing the outdated modules, including astroquery.nrao (e.g. it's no use to keep a totally unsalvagable functionality in the user namespace if/while it's broken).

@jjtobin
Copy link
Author

jjtobin commented Sep 28, 2022

I do not think there is effort available from the NRAO developers to refactor the module for astroquery, unfortunately. I am not sure that the current module is even useful as a basis for development since the new service operates on a completely different principle relative to the old service.

@bsipocz
Copy link
Member

bsipocz commented Sep 28, 2022

I am not sure that the current module is even useful as a basis for development since the new service operates on a completely different principle relative to the old service.

I fully agree. I believe some other TAP-based modules (alma or cadc for example) could be used as a template for the rewrite through.

Either case, I'll go ahead and remove the module, and keep this issue as a reminder that we would very much welcome an NRAO module in astroquery!

@bsipocz bsipocz changed the title NRAO legacy archive will be unavailable to external users ~May 2, 2022 and astroquery.nrao should be deprecated. ENH: Add TAP based NRAO module Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants