Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.54%. Comparing base (7d96ebd) to head (ad2e207).
Report is 30 commits behind head on main.

@@           Coverage Diff           @@
##             main    #3123   +/-   ##
=======================================
  Coverage   67.54%   67.54%           
=======================================
  Files         233      233           
  Lines       18493    18493           
=======================================
  Hits        12491    12491           
  Misses       6002     6002           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

the linelist change seems to be unrelated, but I'm al for wrapping up draft PRs (there is one for linelists already :) )

I've determined that the second part of my suggestion here:
#3121 (comment)
is infeasible. We would have to change the download behavior of FileContainer entirely to gain control over the paths.

Astroquery is using get_readable_fileobj, which then uses astropy tools down to the bottom turtle to find the path. We could hack XDG_CONFIG_HOME, but that is a Bad Idea; we'd be better off refactoring FileContainer, and I think that is a low priority.

https://github.com/astropy/astropy/blob/fda05b894e093a282ec46b1447d2ad24bf8b21da/astropy/utils/data.py#L201

https://github.com/astropy/astropy/blob/fda05b894e093a282ec46b1447d2ad24bf8b21da/astropy/utils/data.py#L357-L359

https://github.com/astropy/astropy/blob/fda05b894e093a282ec46b1447d2ad24bf8b21da/astropy/utils/data.py#L1505

https://github.com/astropy/astropy/blob/fda05b894e093a282ec46b1447d2ad24bf8b21da/astropy/utils/data.py#L1870

https://github.com/astropy/astropy/blob/fda05b894e093a282ec46b1447d2ad24bf8b21da/astropy/config/paths.py#L90

https://github.com/astropy/astropy/blob/fda05b894e093a282ec46b1447d2ad24bf8b21da/astropy/config/paths.py#L23

@bsipocz I'm not sure there's a good test for this. I'll keep working to try to figure one out, but I'd recommend merging this as-is. My by-hand test says it works:

$ python3 -c 'from astroquery.sdss import SDSS; SDSS.get_spectra(plate=827, fiberID=23, mjd=52312, cache=False)'
Downloading https://data.sdss.org/sas/dr17/sdss/spectro/redux/26/spectra/0827/spec-0827-52312-0023.fits
|==========================================================================================================================================================================================================| 892k/892k (100.00%)         0s
$ ls -lh ~/.astropy/cache/download/url/0ad9*
ls: /Users/adam/.astropy/cache/download/url/0ad9*: No such file or directory

OK, let's merge this as is. as for

we'd be better off refactoring FileContainer

Yes, I agree and it's on my roadmap (we'll have to work on some download tools for pyvo, too, so I foresee to upstream or remove or at least refactor a lot of astroquery along the way, too)