-
-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CDMS: fix MOLWT
column starting position
#3094
base: main
Are you sure you want to change the base?
Conversation
MOLWT
column starting positionMOLWT
column starting position
RTD failure is unrelated and will be fixes outside this PR. |
We'll need some tests for this error. I can confirm that 100501 does not work right now: CDMS.query_lines(10*u.GHz, 100*u.GHz, molecule='100501', parse_name_locally=False) I tested one other case, and it worked both before & after: CDMS.query_lines(10*u.GHz, 100*u.GHz, molecule='HCCCN', parse_name_locally=True) so I'm going to approve this, but on my to-do list is to systematically test all molecules for failures like this. |
In addition to putting it on the to-do, please do open an issue for it here, too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test failures are related
Yeah, I'm sorry, the last commit I pushed actually broke a bunch of other molecules. So far from my testing/debugging, it looks like just changing the column numbers will not help, because the format itself is not consistent for all molecules. It needs a bit larger refactor in some parts. I'm still up for fixing this, but couldn't due to my own work. If it's possible, I would like this to be kept open for a few weeks more. |
Now the molecule tag
100501
and others work. Earlier they were crashing withBecause that
-
is part of the signedTAG
.