-
-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partial rewrite of the MOCServer module #3139
base: main
Are you sure you want to change the base?
Conversation
mostly achieved by looking at a small MOC in test_moc_order_param rather than the whole sky
for tables, we use the fact that Table accepts dictionnaries. For MOCs, the dictionnary parsing has been improved in MOCpy > 0.12 and does not require to remove empty orders anymore
Hello @ManonMarchand! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-11-27 15:53:16 UTC |
68d1db0
to
065b393
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3139 +/- ##
==========================================
+ Coverage 67.53% 67.68% +0.15%
==========================================
Files 233 233
Lines 18487 18471 -16
==========================================
+ Hits 12486 12503 +17
+ Misses 6001 5968 -33 ☔ View full report in Codecov by Sentry. |
this is mainly motivated by the new support for time mocs and space-time mocs upstream
065b393
to
199c5d4
Compare
Switching to draft as I asked for a review internally in CDS |
Hello astroquery,
This is a quite big rewrite of the MOS Server module.
The two main motivations behind it were:
query_region
with a MOC would write a real file on the people's current folder. This file would be namedmoc.fits
and could potentially overwrite a pre-existing file with the same name silently.The actual changes in this PR
query_hips
allows to filter only hips in a shortcut rather than having to remember all the time to have to typehips_frame=*
in themeta_data
(convenience method)meta_data
. This was unnecessary, and now the two methods are exactly the same and allow to filter on region and to add a criteria. I was wondering whetherfind_datasets
should be deprecatedcasesensitive
andspacesys
allow to chose whether the query will respect the case, and to chose a specific system for the datasets (ex:mars
,venus
,C
where C is the sky)list_spacesys
that prints the currently available spacesys (can evolve as providers post new datasets)list_fields
to see the possible fields (there are 134 today) sorted by occurrence and with an examplereturn_moc
is no longer oly a boolean. It keeps it former behavior (True means Space MOC) but it can now also take the valuessmoc
,tmoc
, orstmoc
to specify the kind of MOC that should be returnedquery_region
, theregion
argument can now also be amocpy.TimeMOC
and amocpy.STMOC
on top of the previously accepted classesregions
module from the mandatory dependenciesChanges while I was there